moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Code Issues Releases Wiki Activity

multi: call multi_done on connect timeouts

Browse Source 
Failing to do so would make the CURLINFO_TOTAL_TIME timeout to not get
updated correctly and could end up getting reported to the application
completely wrong (way too small).

Reported-by: accountantM on github
Fixes #3602
Closes #3605
This commit is contained in:
Daniel Stenberg 2019-02-24 16:32:04 +01:00
parent 47e540df8f
commit aa7b813ad1
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/multi.c
View File

@ -1606,7 +1606,8 @@ static CURLMcode multi_runsingle(struct Curl_multi *multi,
} }
else if(result) { else if(result) {
/* failure detected */ /* failure detected */
/* Just break, the cleaning up is handled all in one place */ Curl_posttransfer(data);
multi_done(data, result, TRUE);
stream_error = TRUE; stream_error = TRUE;
break; break;
} }