moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-11-12 04:25:08 -05:00
Code Issues Releases Wiki Activity

proxy: reject attempts to use unsupported proxy schemes

Browse Source 
I discovered some people have been using "https://example.com" style
strings as proxy and it "works" (curl doesn't complain) because curl
ignores unknown schemes and then assumes plain HTTP instead.

I think this misleads users into believing curl uses HTTPS to proxies
when it doesn't. Now curl rejects proxy strings using unsupported
schemes instead of just ignoring and defaulting to HTTP.
This commit is contained in:
Daniel Stenberg 2016-08-15 10:46:27 +02:00
parent a5174b022b
commit a96319ebb9
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/url.c
View File

@ -4706,7 +4706,13 @@ static CURLcode parse_proxy(struct Curl_easy *data,
conn->proxytype = CURLPROXY_SOCKS4A; conn->proxytype = CURLPROXY_SOCKS4A;
else if(checkprefix("socks4", proxy) || checkprefix("socks", proxy)) else if(checkprefix("socks4", proxy) || checkprefix("socks", proxy))
conn->proxytype = CURLPROXY_SOCKS4; conn->proxytype = CURLPROXY_SOCKS4;
/* Any other xxx:// : change to http proxy */ else if(checkprefix("http:", proxy))
; /* leave it as HTTP or HTTP/1.0 */
else {
/* Any other xxx:// reject! */
failf(data, "No support for proxy over the \'%s\' scheme", proxy);
return CURLE_COULDNT_CONNECT;
}
} }
else else
proxyptr = proxy; /* No xxx:// head: It's a HTTP proxy */ proxyptr = proxy; /* No xxx:// head: It's a HTTP proxy */