moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-11-14 21:45:13 -05:00
Code Issues Releases Wiki Activity

setopt: return CURLE_BAD_FUNCTION_ARGUMENT on bad argument

Browse Source 
Fixed two return code mixups. CURLE_UNKNOWN_OPTION is saved for when the
option is, yeah, not known. Clarified this in the setopt man page too.

Closes #5993
This commit is contained in:
Daniel Stenberg 2020-09-21 23:27:21 +02:00
parent f4873ebd0b
commit a8e08a87df
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
2 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/libcurl/curl_easy_setopt.3
View File

@ -645,6 +645,9 @@ Strings passed on to libcurl must be shorter than 8000000 bytes, otherwise
\fIcurl_easy_setopt(3)\fP returns \fBCURLE_BAD_FUNCTION_ARGUMENT\fP (added in \fIcurl_easy_setopt(3)\fP returns \fBCURLE_BAD_FUNCTION_ARGUMENT\fP (added in
7.65.0). 7.65.0).
\fBCURLE_BAD_FUNCTION_ARGUMENT\fP is returned when the argument to an option
is invalid, like perhaps out of range.a
If you try to set an option that libcurl doesn't know about, perhaps because If you try to set an option that libcurl doesn't know about, perhaps because
the library is too old to support it or the option was removed in a recent the library is too old to support it or the option was removed in a recent
version, this function will return \fICURLE_UNKNOWN_OPTION\fP. If support for version, this function will return \fICURLE_UNKNOWN_OPTION\fP. If support for

24
lib/setopt.c
View File

@ -430,7 +430,7 @@ CURLcode Curl_vsetopt(struct Curl_easy *data, CURLoption option, va_list param)
primary->version_max = version_max; primary->version_max = version_max;
} }
#else #else
result = CURLE_UNKNOWN_OPTION; result = CURLE_NOT_BUILT_IN;
#endif #endif
break; break;
@ -1077,7 +1077,7 @@ CURLcode Curl_vsetopt(struct Curl_easy *data, CURLoption option, va_list param)
break; break;
default: default:
/* reserve other values for future use */ /* reserve other values for future use */
result = CURLE_UNKNOWN_OPTION; result = CURLE_BAD_FUNCTION_ARGUMENT;
break; break;
} }
break; break;
@ -1230,21 +1230,13 @@ CURLcode Curl_vsetopt(struct Curl_easy *data, CURLoption option, va_list param)
* An FTP/SFTP option that modifies an upload to create missing * An FTP/SFTP option that modifies an upload to create missing
* directories on the server. * directories on the server.
*/ */
switch(va_arg(param, long)) { arg = va_arg(param, long);
case 0:
data->set.ftp_create_missing_dirs = 0;
break;
case 1:
data->set.ftp_create_missing_dirs = 1;
break;
case 2:
data->set.ftp_create_missing_dirs = 2;
break;
default:
/* reserve other values for future use */ /* reserve other values for future use */
result = CURLE_UNKNOWN_OPTION; if((arg < CURLFTP_CREATE_DIR_NONE) ||
break; (arg > CURLFTP_CREATE_DIR_RETRY))
} result = CURLE_BAD_FUNCTION_ARGUMENT;
else
data->set.ftp_create_missing_dirs = (int)arg;
break; break;
case CURLOPT_READDATA: case CURLOPT_READDATA:
/* /*