Arve Knudsen found a flaw in curl_multi_fdset() for systems where

curl_socket_t is unsigned (like Windows) that could cause it to wrongly
return a max fd of -1.
This commit is contained in:
Daniel Stenberg 2006-06-23 22:07:06 +00:00
parent dfe1884c25
commit a8ac6f1dc1
3 changed files with 8 additions and 2 deletions

View File

@ -6,6 +6,11 @@
Changelog Changelog
Daniel (23 June 2006)
- Arve Knudsen found a flaw in curl_multi_fdset() for systems where
curl_socket_t is unsigned (like Windows) that could cause it to wrongly
return a max fd of -1.
Daniel (20 June 2006) Daniel (20 June 2006)
- Peter Silva introduced CURLOPT_MAX_SEND_SPEED_LARGE and - Peter Silva introduced CURLOPT_MAX_SEND_SPEED_LARGE and
CURLOPT_MAX_RECV_SPEED_LARGE that limit tha maximum rate libcurl is allowed CURLOPT_MAX_RECV_SPEED_LARGE that limit tha maximum rate libcurl is allowed

View File

@ -16,6 +16,7 @@ This release includes the following changes:
This release includes the following bugfixes: This release includes the following bugfixes:
o curl_multi_fdset() could return a crazy max_fd value
o Made -K on a file that couldn't be read cause a warning to be displayed. o Made -K on a file that couldn't be read cause a warning to be displayed.
Other curl-related news: Other curl-related news:
@ -30,6 +31,6 @@ New curl mirrors:
This release would not have looked like this without help, code, reports and This release would not have looked like this without help, code, reports and
advice from friends like these: advice from friends like these:
Dan Fandrich, Peter Silva Dan Fandrich, Peter Silva, Arve Knudsen
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

View File

@ -504,7 +504,7 @@ CURLMcode curl_multi_fdset(CURLM *multi_handle,
/* this socket is unused, break out of loop */ /* this socket is unused, break out of loop */
break; break;
else { else {
if(s > (curl_socket_t)this_max_fd) if((int)s > this_max_fd)
this_max_fd = (int)s; this_max_fd = (int)s;
} }
} }