moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-22 16:18:48 -05:00
Code Issues Releases Wiki Activity

- Liza Alenchery mentioned a problem with re-used SCP connection when a bad

Browse Source 
auth is used, as it caused a crash. I failed to repeat the issue, but still
  made a change that now forces the TCP connection used for a freed SCP
  session to get closed and not be re-used.
This commit is contained in:
Daniel Stenberg 2009-10-30 22:28:56 +00:00
parent d68f215f03
commit a76f4ab7dd
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGES
View File

@ -7,6 +7,11 @@
Changelog Changelog
Daniel Stenberg (30 Oct 2009) Daniel Stenberg (30 Oct 2009)
- Liza Alenchery mentioned a problem with re-used SCP connection when a bad
auth is used, as it caused a crash. I failed to repeat the issue, but still
made a change that now forces the TCP connection used for a freed SCP
session to get closed and not be re-used.
- "Tom" posted a bug report that mentioned how libcurl did wrong when doing a - "Tom" posted a bug report that mentioned how libcurl did wrong when doing a
POST using a read callback, with Digest authentication and POST using a read callback, with Digest authentication and
"Transfer-Encoding: chunked" enforced. I would then cause the first request "Transfer-Encoding: chunked" enforced. I would then cause the first request

4
RELEASE-NOTES
View File

@ -43,6 +43,7 @@ This release includes the following bugfixes:
o use pkg-config to find out libssh2 installation details in configure o use pkg-config to find out libssh2 installation details in configure
o unparsable cookie expire dates make cookies get treated as session coookies o unparsable cookie expire dates make cookies get treated as session coookies
o POST with Digest authentication and "Transfer-Encoding: chunked" o POST with Digest authentication and "Transfer-Encoding: chunked"
o SCP connection re-use with wrong auth
This release includes the following known bugs: This release includes the following known bugs:
@ -55,6 +56,7 @@ advice from friends like these:
Michal Marek, Eric Wong, Guenter Knauf, Peter Sylvester, Daniel Johnson, Michal Marek, Eric Wong, Guenter Knauf, Peter Sylvester, Daniel Johnson,
Claes Jakobsson, Sven Anders, Chris Mumford, John P. McCaskey, Claes Jakobsson, Sven Anders, Chris Mumford, John P. McCaskey,
Constantine Sapuntzakis, Michael Stillwell, Tom Mueller, Dan Fandrich, Constantine Sapuntzakis, Michael Stillwell, Tom Mueller, Dan Fandrich,
Kevin Baughman, John Dennis, Ray Dassen, Johan van Selst, Dima Barsky Kevin Baughman, John Dennis, Ray Dassen, Johan van Selst, Dima Barsky,
Liza Alenchery
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

1
lib/ssh.c
View File

@ -2221,6 +2221,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
} }
sshc->ssh_session = NULL; sshc->ssh_session = NULL;
} }
conn->bits.close = TRUE;
sshc->nextstate = SSH_NO_STATE; sshc->nextstate = SSH_NO_STATE;
state(conn, SSH_STOP); state(conn, SSH_STOP);
result = sshc->actualcode; result = sshc->actualcode;