moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-25 01:28:51 -05:00
Code Issues Releases Wiki Activity

reuse_conn(): free old_conn->options

Browse Source 
This fixes a memory leak when CURLOPT_LOGIN_OPTIONS is used, together with
connection reuse.

I found this with oss-fuzz on GDAL and curl master:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9582
I couldn't reproduce with the oss-fuzz original test case, but looking
at curl source code pointed to this well reproducable leak.

Closes #2790
This commit is contained in:
Even Rouault 2018-07-25 11:22:51 +02:00 committed by Daniel Stenberg
parent d0d48b4276
commit a7091ba75d
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/url.c
View File

@ -3971,6 +3971,7 @@ static void reuse_conn(struct connectdata *old_conn,
Curl_safefree(old_conn->user); Curl_safefree(old_conn->user);
Curl_safefree(old_conn->passwd); Curl_safefree(old_conn->passwd);
Curl_safefree(old_conn->options);
Curl_safefree(old_conn->http_proxy.user); Curl_safefree(old_conn->http_proxy.user);
Curl_safefree(old_conn->socks_proxy.user); Curl_safefree(old_conn->socks_proxy.user);
Curl_safefree(old_conn->http_proxy.passwd); Curl_safefree(old_conn->http_proxy.passwd);