moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Code Issues Releases Wiki Activity

juggle() actually returns bool.

Browse Source 
Remove redundant and unreachable log message.
This commit is contained in:
Yang Tse 2008-02-19 18:51:08 +00:00
parent 7b5c86033a
commit 9df37b93df
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/server/sockfilt.c
View File

@ -160,9 +160,9 @@ enum sockmode {
if sockfd is CURL_SOCKET_BAD, listendfd is a listening socket we must if sockfd is CURL_SOCKET_BAD, listendfd is a listening socket we must
accept() accept()
*/ */
static int juggle(curl_socket_t *sockfdp, static bool juggle(curl_socket_t *sockfdp,
curl_socket_t listenfd, curl_socket_t listenfd,
enum sockmode *mode) enum sockmode *mode)
{ {
struct timeval timeout; struct timeval timeout;
fd_set fds_read; fd_set fds_read;
@ -308,18 +308,12 @@ static int juggle(curl_socket_t *sockfdp,
buffer_len = (ssize_t)strtol((char *)buffer, NULL, 16); buffer_len = (ssize_t)strtol((char *)buffer, NULL, 16);
if (buffer_len > (ssize_t)sizeof(buffer)) { if (buffer_len > (ssize_t)sizeof(buffer)) {
logmsg("Buffer size %d too small for data size %d", logmsg("ERROR: Buffer size (%ld bytes) too small for data size "
(int)sizeof(buffer), buffer_len); "(%ld bytes)", (long)sizeof(buffer), (long)buffer_len);
return FALSE; return FALSE;
} }
logmsg("> %d bytes data, server => client", buffer_len); logmsg("> %d bytes data, server => client", buffer_len);
if(buffer_len > (ssize_t)sizeof(buffer)) {
logmsg("ERROR: %d bytes of data does not fit within the %d "
"bytes buffer", buffer_len, sizeof(buffer));
return FALSE;
}
/* /*
* To properly support huge data chunks, we need to repeat the call * To properly support huge data chunks, we need to repeat the call
* to read() until we're done or it fails. * to read() until we're done or it fails.