diff --git a/lib/getenv.c b/lib/getenv.c index e444a6a3a..a50226e73 100644 --- a/lib/getenv.c +++ b/lib/getenv.c @@ -27,25 +27,48 @@ #include "memdebug.h" -static -char *GetEnv(const char *variable) +static char *GetEnv(const char *variable) { #if defined(_WIN32_WCE) || defined(CURL_WINDOWS_APP) (void)variable; return NULL; -#else -#ifdef WIN32 - char env[4096]; - char *temp = getenv(variable); - env[0] = '\0'; - if(temp != NULL) - ExpandEnvironmentStringsA(temp, env, sizeof(env)); - return (env[0] != '\0')?strdup(env):NULL; +#elif defined(WIN32) + /* This uses Windows API instead of C runtime getenv() to get the environment + variable since some changes aren't always visible to the latter. #4774 */ + char *buf = NULL; + char *tmp; + DWORD bufsize; + DWORD rc = 1; + const DWORD max = 32768; /* max env var size from MSCRT source */ + + for(;;) { + tmp = realloc(buf, rc); + if(!tmp) { + free(buf); + return NULL; + } + + buf = tmp; + bufsize = rc; + + /* It's possible for rc to be 0 if the variable was found but empty. + Since getenv doesn't make that distinction we ignore it as well. */ + rc = GetEnvironmentVariableA(variable, buf, bufsize); + if(!rc || rc == bufsize || rc > max) { + free(buf); + return NULL; + } + + /* if rc < bufsize then rc is bytes written not including null */ + if(rc < bufsize) + return buf; + + /* else rc is bytes needed, try again */ + } #else char *env = getenv(variable); return (env && env[0])?strdup(env):NULL; #endif -#endif } char *curl_getenv(const char *v) diff --git a/src/tool_homedir.c b/src/tool_homedir.c index 6bc69551e..e4ea97d38 100644 --- a/src/tool_homedir.c +++ b/src/tool_homedir.c @@ -25,38 +25,23 @@ # include #endif +#include + #include "tool_homedir.h" #include "memdebug.h" /* keep this as LAST include */ -static char *GetEnv(const char *variable, char do_expand) +static char *GetEnv(const char *variable) { - char *env = NULL; -#ifdef WIN32 - char buf1[1024], buf2[1024]; - DWORD rc; + char *dupe, *env; - /* Don't use getenv(); it doesn't find variable added after program was - * started. Don't accept truncated results (i.e. rc >= sizeof(buf1)). */ + env = curl_getenv(variable); + if(!env) + return NULL; - rc = GetEnvironmentVariableA(variable, buf1, sizeof(buf1)); - if(rc > 0 && rc < sizeof(buf1)) { - env = buf1; - variable = buf1; - } - if(do_expand && strchr(variable, '%')) { - /* buf2 == variable if not expanded */ - rc = ExpandEnvironmentStringsA(variable, buf2, sizeof(buf2)); - if(rc > 0 && rc < sizeof(buf2) && - !strchr(buf2, '%')) /* no vars still unexpanded */ - env = buf2; - } -#else - (void)do_expand; - /* no length control */ - env = getenv(variable); -#endif - return (env && env[0]) ? strdup(env) : NULL; + dupe = strdup(env); + curl_free(env); + return dupe; } /* return the home directory of the current user as an allocated string */ @@ -64,11 +49,11 @@ char *homedir(void) { char *home; - home = GetEnv("CURL_HOME", FALSE); + home = GetEnv("CURL_HOME"); if(home) return home; - home = GetEnv("HOME", FALSE); + home = GetEnv("HOME"); if(home) return home; @@ -86,10 +71,18 @@ char *homedir(void) } #endif /* PWD-stuff */ #ifdef WIN32 - home = GetEnv("APPDATA", TRUE); - if(!home) - home = GetEnv("%USERPROFILE%\\Application Data", TRUE); /* Normally only - on Win-2K/XP */ + home = GetEnv("APPDATA"); + if(!home) { + char *env = GetEnv("USERPROFILE"); + if(env) { + char *path = curl_maprintf("%s\\Application Data", env); + if(path) { + home = strdup(path); + curl_free(path); + } + free(env); + } + } #endif /* WIN32 */ return home; }