moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-11-15 22:15:13 -05:00
Code Issues Releases Wiki Activity

smtp: Removed bytecountp from the per-request structure

Browse Source 
Removed this pointer to a downloaded bytes counter because it was set in
smtp_init() to point to the same variable the transfer functions keep
the count in (k->bytecount), effectively making the code in transfer.c
"*k->bytecountp = k->bytecount" a no-op.
This commit is contained in:
Steve Holme 2013-02-25 22:28:14 +00:00
parent a390454728
commit 9d45391347
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/smtp.c
View File

@ -1091,7 +1091,6 @@ static CURLcode smtp_state_data_resp(struct connectdata *conn, int smtpcode,
smtpstate instate) smtpstate instate)
{ {
struct SessionHandle *data = conn->data; struct SessionHandle *data = conn->data;
struct SMTP *smtp = data->state.proto.smtp;
(void)instate; /* no use for this yet */ (void)instate; /* no use for this yet */
@ -1102,7 +1101,7 @@ static CURLcode smtp_state_data_resp(struct connectdata *conn, int smtpcode,
/* SMTP upload */ /* SMTP upload */
Curl_setup_transfer(conn, -1, -1, FALSE, NULL, /* no download */ Curl_setup_transfer(conn, -1, -1, FALSE, NULL, /* no download */
FIRSTSOCKET, smtp->bytecountp); FIRSTSOCKET, NULL);
/* End of do phase */ /* End of do phase */
state(conn, SMTP_STOP); state(conn, SMTP_STOP);
@ -1288,9 +1287,6 @@ static CURLcode smtp_init(struct connectdata *conn)
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
/* Get some initial data into the smtp struct */
smtp->bytecountp = &data->req.bytecount;
return CURLE_OK; return CURLE_OK;
} }

1
lib/smtp.h
View File

@ -58,7 +58,6 @@ typedef enum {
perhaps the SessionHandle is changed between the times the connection is perhaps the SessionHandle is changed between the times the connection is
used. */ used. */
struct SMTP { struct SMTP {
curl_off_t *bytecountp;
curl_pp_transfer transfer; curl_pp_transfer transfer;
struct curl_slist *rcpt; /* Recipient list */ struct curl_slist *rcpt; /* Recipient list */
}; };