moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-23 16:48:49 -05:00
Code Issues Releases Wiki Activity

CURLOPT_DNS_USE_GLOBAL_CACHE: deprecated

Browse Source 
Disable the CURLOPT_DNS_USE_GLOBAL_CACHE option and mark it for
deprecation and complete removal in six months.

Bug: https://curl.haxx.se/mail/lib-2018-09/0010.html
Closes #2942
This commit is contained in:
Daniel Stenberg 2018-09-05 00:05:46 +02:00
parent 25fd1057c9
commit 7c5837e792
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
docs/DEPRECATE.md
View File

@ -70,3 +70,24 @@ libcurl code.
Left to answer: should the *setopt() function start to return error when these Left to answer: should the *setopt() function start to return error when these
options are set to be able to tell when they're trying to use options that are options are set to be able to tell when they're trying to use options that are
no longer around or should we maintain behavior as much as possible? no longer around or should we maintain behavior as much as possible?
## CURLOPT_DNS_USE_GLOBAL_CACHE
This option makes libcurl use a global non-thread-safe cache for DNS if
enabled. The option has been marked as "obsolete" in the header file and in
documentation for several years already.
There's proper and safe method alternative provided since many years: the
share API.
### State
In curl 7.62.0 setting this option to TRUE will not have any effect. The
global cache will not be enabled. The code still remains so it is easy to
revert if need be.
### Removal
Remove all global-cache related code from curl around April 2019 (might be
7.66.0).

2
lib/setopt.c
View File

@ -127,9 +127,11 @@ CURLcode Curl_vsetopt(struct Curl_easy *data, CURLoption option,
data->set.dns_cache_timeout = arg; data->set.dns_cache_timeout = arg;
break; break;
case CURLOPT_DNS_USE_GLOBAL_CACHE: case CURLOPT_DNS_USE_GLOBAL_CACHE:
#if 0 /* deprecated */
/* remember we want this enabled */ /* remember we want this enabled */
arg = va_arg(param, long); arg = va_arg(param, long);
data->set.global_dns_cache = (0 != arg) ? TRUE : FALSE; data->set.global_dns_cache = (0 != arg) ? TRUE : FALSE;
#endif
break; break;
case CURLOPT_SSL_CIPHER_LIST: case CURLOPT_SSL_CIPHER_LIST:
/* set a list of cipher we want to use in the SSL connection */ /* set a list of cipher we want to use in the SSL connection */