moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-22 08:08:50 -05:00
Code Issues Releases Wiki Activity

David Wright filed bug report #1849764

Browse Source 
(http://curl.haxx.se/bug/view.cgi?id=1849764) with an included fix. He
identified a problem for re-used connections that previously had sent
Expect: 100-continue and in some situations the subsequent POST (that didn't
use Expect:) still had the internal flag set for its use. David's fix (that
makes the setting of the flag in every single request unconditionally) is
fine and is now used!
This commit is contained in:
Daniel Stenberg 2007-12-13 10:00:06 +00:00
parent dc24540ed1
commit 7b1a22147e
3 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
CHANGES
View File

@ -7,6 +7,15 @@
Changelog Changelog
Daniel S (13 Dec 2007)
- David Wright filed bug report #1849764
(http://curl.haxx.se/bug/view.cgi?id=1849764) with an included fix. He
identified a problem for re-used connections that previously had sent
Expect: 100-continue and in some situations the subsequent POST (that didn't
use Expect:) still had the internal flag set for its use. David's fix (that
makes the setting of the flag in every single request unconditionally) is
fine and is now used!
Daniel S (12 Dec 2007) Daniel S (12 Dec 2007)
- Gilles Blanc made the curl tool enable SO_KEEPALIVE for the connections and - Gilles Blanc made the curl tool enable SO_KEEPALIVE for the connections and
added the --no-keep-alive option that can disable that on demand. added the --no-keep-alive option that can disable that on demand.

3
RELEASE-NOTES
View File

@ -35,6 +35,7 @@ This release includes the following bugfixes:
o no longer default-appends ;type= on FTP URLs thru proxies o no longer default-appends ;type= on FTP URLs thru proxies
o SSL session id caching o SSL session id caching
o POST with callback over proxy requiring NTLM or Digest o POST with callback over proxy requiring NTLM or Digest
o Expect: 100-continue flaw on re-used connection with POSTs
This release includes the following known bugs: This release includes the following known bugs:
@ -55,6 +56,6 @@ advice from friends like these:
Dan Fandrich, Gisle Vanem, Toby Peterson, Yang Tse, Daniel Black, Dan Fandrich, Gisle Vanem, Toby Peterson, Yang Tse, Daniel Black,
Robin Johnson, Michal Marek, Ates Goral, Andres Garcia, Rob Crittenden, Robin Johnson, Michal Marek, Ates Goral, Andres Garcia, Rob Crittenden,
Emil Romanus, Alessandro Vesely, Ray Pekowski, Spacen Jasset, Andrew Moise, Emil Romanus, Alessandro Vesely, Ray Pekowski, Spacen Jasset, Andrew Moise,
Gilles Blanc Gilles Blanc, David Wright
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

22
lib/http.c
View File

@ -2613,17 +2613,19 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
return result; return result;
} }
if(data->set.postfields) { /* For really small posts we don't use Expect: headers at all, and for
the somewhat bigger ones we allow the app to disable it. Just make
sure that the expect100header is always set to the preferred value
here. */
if(postsize > TINY_INITIAL_POST_SIZE) {
result = expect100(data, req_buffer);
if(result)
return result;
}
else
data->state.expect100header = FALSE;
/* for really small posts we don't use Expect: headers at all, and for if(data->set.postfields) {
the somewhat bigger ones we allow the app to disable it */
if(postsize > TINY_INITIAL_POST_SIZE) {
result = expect100(data, req_buffer);
if(result)
return result;
}
else
data->state.expect100header = FALSE;
if(!data->state.expect100header && if(!data->state.expect100header &&
(postsize < MAX_INITIAL_POST_SIZE)) { (postsize < MAX_INITIAL_POST_SIZE)) {