moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-22 08:08:50 -05:00
Code Issues Releases Wiki Activity

- The tests/runtests.pl script now checks to see if the test case that runs is

Browse Source 
present in the tests/data/Makefile.am and outputs a notice message on the
  screen if not. Each test file has to be included in that Makefile.am to get
  included in release archives and forgetting to add files there is a common
  mistake. This is an attempt to make it harder to forget.
This commit is contained in:
Daniel Stenberg 2010-01-11 15:50:30 +00:00
parent 5bec1b1cf0
commit 78b7d7f7a8
3 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGES
View File

@ -6,6 +6,13 @@
Changelog Changelog
Daniel Stenberg (11 Jan 2010)
- The tests/runtests.pl script now checks to see if the test case that runs is
present in the tests/data/Makefile.am and outputs a notice message on the
screen if not. Each test file has to be included in that Makefile.am to get
included in release archives and forgetting to add files there is a common
mistake. This is an attempt to make it harder to forget.
Daniel Stenberg (9 Jan 2010) Daniel Stenberg (9 Jan 2010)
- Johan van Selst found and fixed a OpenSSL session ref count leak: - Johan van Selst found and fixed a OpenSSL session ref count leak:

2
tests/data/Makefile.am
View File

@ -84,3 +84,5 @@ filecheck:
rm -rf test-place ; \ rm -rf test-place ; \
exit $$RC exit $$RC
show:
@echo $(EXTRA_DIST)

15
tests/runtests.pl
View File

@ -425,6 +425,15 @@ sub checkcmd {
} }
} }
#######################################################################
# Get the list of tests that the tests/data/Makefile.am knows about!
#
my $disttests;
sub get_disttests {
my @dist = `cd $srcdir/data && make show`;
$disttests = join("", @dist);
}
####################################################################### #######################################################################
# Check for a command in the PATH of the machine running curl. # Check for a command in the PATH of the machine running curl.
# #
@ -1882,6 +1891,11 @@ sub singletest {
# timestamp test preparation start # timestamp test preparation start
$timeprepini{$testnum} = Time::HiRes::time() if($timestats); $timeprepini{$testnum} = Time::HiRes::time() if($timestats);
if($disttests !~ /\Wtest$testnum\W/ ) {
print STDERR "NOTICE: data/test$testnum is not present in tests/data/Makefile.am!\n";
}
# load the test case file definition # load the test case file definition
if(loadtest("${TESTDIR}/test${testnum}")) { if(loadtest("${TESTDIR}/test${testnum}")) {
if($verbose) { if($verbose) {
@ -3307,6 +3321,7 @@ mkdir($LOGDIR, 0777);
# #
if(!$listonly) { if(!$listonly) {
get_disttests();
checksystem(); checksystem();
} }