moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2025-02-28 09:21:50 -05:00
Code Issues Releases Wiki Activity

Curl_do: avoid using stale conn pointer

Browse Source 
Since the original `conn' pointer was used after the `connectdata' it
points to has been closed/cleaned up by Curl_reconnect_request it caused
a crash. We must make sure to use the newly created connection instead!

URL: http://curl.haxx.se/mail/lib-2010-12/0202.html
This commit is contained in:
Pasha Kuznetsov 2010-12-18 22:35:37 +01:00 committed by Daniel Stenberg
parent 8ab137b2bc
commit 6b5dc72575
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/url.c
View File

@ -5347,12 +5347,13 @@ CURLcode Curl_do(struct connectdata **connp, bool *done)
if(result == CURLE_OK) {
/* ... finally back to actually retry the DO phase */
conn = *connp; /* re-assign conn since Curl_reconnect_request
creates a new connection */
result = conn->handler->do_it(conn, done);
}
}
else {
else
return result;
}
}
if((result == CURLE_OK) && *done)