moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Code Issues Releases Wiki Activity

runtests: keep logfiles around by default

Browse Source 
Make '-k' a no-op. The singletest function now clears the log directory
BEFORE each individual test and not after, which makes it possible to
always keep the logfiles around after a test has been run. No need to
specify -k anymore. Keeping the option parsing around to work with users
of old habits.

Some tests also didn't work properly when -k was used (since the old
logs would be kep when a new test starts) which this change also fixes.

Closes #4035
This commit is contained in:
Daniel Stenberg 2019-06-17 14:20:51 +02:00
parent 6c2b7d44e3
commit 6617db6a7e
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/runtests.pl
View File

@ -3202,6 +3202,9 @@ sub singletest {
my $cmd;
my $disablevalgrind;
# fist, remove all lingering log files
cleardir($LOGDIR);
# copy test number to a global scope var, this allows
# testnum checking when starting test harness servers.
$testnumcheck = $testnum;
@ -3862,9 +3865,6 @@ sub singletest {
# Skip all the verification on torture tests
if ($torture) {
if(!$cmdres && !$keepoutfiles) {
cleardir($LOGDIR);
}
# timestamp test result verification end
$timevrfyend{$testnum} = Time::HiRes::time();
return $cmdres;
@ -4295,10 +4295,6 @@ sub singletest {
logmsg "PASS: $testnum - $testname\n";
}
# the test succeeded, remove all log files
if(!$keepoutfiles) {
cleardir($LOGDIR);
}
return 0;
}