moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-21 23:58:49 -05:00
Code Issues Releases Wiki Activity

inet_pton.c: Fix MSVC run-time check failure

Browse Source 
Visual Studio complains with a message box:

"Run-Time Check Failure #1 - A cast to a smaller data type has caused a
loss of data.  If this was intentional, you should mask the source of
the cast with the appropriate bitmask.

For example:
char c = (i & 0xFF);

Changing the code in this way will not affect the quality of the
resulting optimized code."

This is because only 'val' is cast to unsigned char, so the "& 0xff" has
no effect.

Closes #387
This commit is contained in:
Marcel Raad 2015-08-18 09:39:38 +02:00 committed by Daniel Stenberg
parent 1f1f131e09
commit 618dfd65e4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/inet_pton.c
View File

@ -189,7 +189,7 @@ inet_pton6(const char *src, unsigned char *dst)
if(tp + INT16SZ > endp)
return (0);
*tp++ = (unsigned char) (val >> 8) & 0xff;
*tp++ = (unsigned char) val & 0xff;
*tp++ = (unsigned char) (val & 0xff);
saw_xdigit = 0;
val = 0;
continue;