moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2025-03-11 15:50:48 -04:00
Code Issues Releases Wiki Activity

Scott Cantor filed bug report #1766320

Browse Source 
(http://curl.haxx.se/bug/view.cgi?id=1766320) pointing out that the libcurl
code accessed two curl_easy_setopt() options (CURLOPT_DNS_CACHE_TIMEOUT and
CURLOPT_DNS_USE_GLOBAL_CACHE) as ints even though they're documented to be
passed in as longs, and that makes a difference on 64 bit architectures.
This commit is contained in:
Daniel Stenberg 2007-08-02 20:10:28 +00:00
parent 035ee257c8
commit 5ec786b02e
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@ -7,6 +7,12 @@
Changelog Changelog
Daniel S (2 August 2007) Daniel S (2 August 2007)
- Scott Cantor filed bug report #1766320
(http://curl.haxx.se/bug/view.cgi?id=1766320) pointing out that the libcurl
code accessed two curl_easy_setopt() options (CURLOPT_DNS_CACHE_TIMEOUT and
CURLOPT_DNS_USE_GLOBAL_CACHE) as ints even though they're documented to be
passed in as longs, and that makes a difference on 64 bit architectures.
- Dmitriy Sergeyev reported a regression: resumed file:// transfers broke - Dmitriy Sergeyev reported a regression: resumed file:// transfers broke
after 7.16.2. This is much due to the different treatment file:// gets after 7.16.2. This is much due to the different treatment file:// gets
internally, but now I added test 231 to make it less likely to happen again internally, but now I added test 231 to make it less likely to happen again

4
RELEASE-NOTES
View File

@ -33,6 +33,7 @@ This release includes the following bugfixes:
o AIX 4 and 5 get to use non-blocking sockets o AIX 4 and 5 get to use non-blocking sockets
o small POST with NTLM o small POST with NTLM
o resumed file:// transfers o resumed file:// transfers
o CURLOPT_DNS_CACHE_TIMEOUT and CURLOPT_DNS_USE_GLOBAL_CACHE are 64 bit "clean"
This release includes the following known bugs: This release includes the following known bugs:
@ -54,6 +55,7 @@ advice from friends like these:
Dan Fandrich, Song Ma, Daniel Black, Giancarlo Formicuccia, Shmulik Regev, Dan Fandrich, Song Ma, Daniel Black, Giancarlo Formicuccia, Shmulik Regev,
Daniel Cater, Colin Hogben, Jofell Gallardo, Daniel Johnson, Daniel Cater, Colin Hogben, Jofell Gallardo, Daniel Johnson,
Ralf S. Engelschall, James Housley, Chris Flerackers, Patrick Monnerat, Ralf S. Engelschall, James Housley, Chris Flerackers, Patrick Monnerat,
Jayesh A Shah, Greg Zavertnik, Peter O'Gorman, Greg Morse, Dmitriy Sergeyev Jayesh A Shah, Greg Zavertnik, Peter O'Gorman, Greg Morse, Dmitriy Sergeyev,
Scott Cantor
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

7
lib/url.c
View File

@ -690,14 +690,13 @@ CURLcode Curl_setopt(struct SessionHandle *data, CURLoption option,
switch(option) { switch(option) {
case CURLOPT_DNS_CACHE_TIMEOUT: case CURLOPT_DNS_CACHE_TIMEOUT:
data->set.dns_cache_timeout = va_arg(param, int); data->set.dns_cache_timeout = va_arg(param, long);
break; break;
case CURLOPT_DNS_USE_GLOBAL_CACHE: case CURLOPT_DNS_USE_GLOBAL_CACHE:
{ {
int use_cache = va_arg(param, int); long use_cache = va_arg(param, long);
if (use_cache) { if (use_cache)
Curl_global_host_cache_init(); Curl_global_host_cache_init();
}
data->set.global_dns_cache = (bool)(0 != use_cache); data->set.global_dns_cache = (bool)(0 != use_cache);
} }