diff --git a/lib/sslgen.c b/lib/sslgen.c index d2d0e303e..887b95ff4 100644 --- a/lib/sslgen.c +++ b/lib/sslgen.c @@ -611,6 +611,9 @@ int Curl_ssl_init_certinfo(struct SessionHandle * data, return 0; } +/* + * 'value' is NOT a zero terminated string + */ CURLcode Curl_ssl_push_certinfo_len(struct SessionHandle *data, int certnum, const char *label, @@ -621,12 +624,22 @@ CURLcode Curl_ssl_push_certinfo_len(struct SessionHandle *data, char * output; struct curl_slist * nl; CURLcode res = CURLE_OK; + size_t labellen = strlen(label); + size_t outlen = labellen + 1 + valuelen + 1; /* label:value\0 */ - /* Add an information record for a particular certificate. */ - output = curl_maprintf("%s:%.*s", label, valuelen, value); + output = malloc(outlen); if(!output) return CURLE_OUT_OF_MEMORY; + /* sprintf the label and colon */ + snprintf(output, outlen, "%s:", label); + + /* memcpy the value (it might not be zero terminated) */ + memcpy(&output[labellen+1], value, valuelen); + + /* zero terminate the output */ + output[labellen + 1 + valuelen] = 0; + nl = Curl_slist_append_nodup(ci->certinfo[certnum], output); if(!nl) { free(output);