moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-25 09:38:54 -05:00
Code Issues Releases Wiki Activity

urlapi: don't set value which is never read

Browse Source 
In the CURLUPART_URL case, there is no codepath which invokes url
decoding so remove the assignment of the urldecode variable. This
fixes the deadstore bug-report from clang static analysis.

Closes #3015
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
This commit is contained in:
Daniel Gustafsson 2018-09-19 13:44:10 +02:00
parent 056cc37ed4
commit 522e647cc5
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/urlapi.c
View File

@ -970,7 +970,6 @@ CURLUcode curl_url_get(CURLU *u, CURLUPart what,
char *scheme; char *scheme;
char *options = u->options; char *options = u->options;
char *port = u->port; char *port = u->port;
urldecode = FALSE; /* not for the whole thing */
if(u->scheme && strcasecompare("file", u->scheme)) { if(u->scheme && strcasecompare("file", u->scheme)) {
url = aprintf("file://%s%s%s", url = aprintf("file://%s%s%s",
u->path, u->path,