moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-22 08:08:50 -05:00
Code Issues Releases Wiki Activity

smtp: Fixed handling of multiline server greeting responses

Browse Source 
Incorrectly processed multiline server greeting responses as "wanted"
continue responses in smtp_endofresp(), from commit f16c0de4e9,
which in turn broke the SMTP server detection in the test suite,
because the EHLO command would not be sent.
This commit is contained in:
Steve Holme 2013-11-15 12:50:37 +00:00
parent 90ec8763a5
commit 4a9fe26837
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/smtp.c
View File

@ -228,6 +228,7 @@ static void smtp_to_smtps(struct connectdata *conn)
static bool smtp_endofresp(struct connectdata *conn, char *line, size_t len, static bool smtp_endofresp(struct connectdata *conn, char *line, size_t len,
int *resp) int *resp)
{ {
struct smtp_conn *smtpc = &conn->proto.smtpc;
bool result = FALSE; bool result = FALSE;
/* Nothing for us */ /* Nothing for us */
@ -247,7 +248,7 @@ static bool smtp_endofresp(struct connectdata *conn, char *line, size_t len,
*resp = 0; *resp = 0;
} }
/* Do we have a multiline (continuation) response? */ /* Do we have a multiline (continuation) response? */
else if(line[3] == '-') { else if(line[3] == '-' && smtpc->state == SMTP_EHLO) {
result = TRUE; result = TRUE;
*resp = 1; /* Internal response code */ *resp = 1; /* Internal response code */
} }