moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-21 23:58:49 -05:00
Code Issues Releases Wiki Activity

url: remove arg value check from CURLOPT_SSH_AUTH_TYPES

Browse Source 
Since CURLSSH_AUTH_ANY (aka CURLSSH_AUTH_DEFAULT) is ~0 an arg value
check on this option is incorrect; we have to accept any value.

Prior to this change since f121575 (7.56.1+) CURLOPT_SSH_AUTH_TYPES
erroneously rejected CURLSSH_AUTH_ANY with CURLE_BAD_FUNCTION_ARGUMENT.

Bug: https://github.com/curl/curl/commit/f121575#commitcomment-25347120
This commit is contained in:
Jay Satiro 2017-11-04 18:36:07 -04:00
parent 685ef13057
commit 462f3cac34
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/url.c
View File

@ -2710,10 +2710,7 @@ CURLcode Curl_setopt(struct Curl_easy *data, CURLoption option,
#ifdef USE_LIBSSH2 #ifdef USE_LIBSSH2
/* we only include SSH options if explicitly built to support SSH */ /* we only include SSH options if explicitly built to support SSH */
case CURLOPT_SSH_AUTH_TYPES: case CURLOPT_SSH_AUTH_TYPES:
arg = va_arg(param, long); data->set.ssh_auth_types = va_arg(param, long);
if(arg < CURLSSH_AUTH_NONE)
return CURLE_BAD_FUNCTION_ARGUMENT;
data->set.ssh_auth_types = arg;
break; break;
case CURLOPT_SSH_PUBLIC_KEYFILE: case CURLOPT_SSH_PUBLIC_KEYFILE: