moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-11-11 20:15:03 -05:00
Code Issues Releases Wiki Activity

Immanuel pointed out that public key SSH auth failed if no public/private

Browse Source 
key was specified and there was no HOME environment variable, and then it
didn't continue to try the other auth methods. Now it will instead try to
get the files id_dsa.pub and id_dsa from the current directory if none of
the two conditions were met.
This commit is contained in:
Daniel Stenberg 2007-09-18 21:14:28 +00:00
parent 0159636373
commit 45fd6685bd
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGES
View File

@ -6,6 +6,13 @@
Changelog Changelog
Daniel S (18 September 2007)
- Immanuel pointed out that public key SSH auth failed if no public/private
key was specified and there was no HOME environment variable, and then it
didn't continue to try the other auth methods. Now it will instead try to
get the files id_dsa.pub and id_dsa from the current directory if none of
the two conditions were met.
Dan F (17 September 2007) Dan F (17 September 2007)
- Added hooks to the test suite to make it possible to test a curl running - Added hooks to the test suite to make it possible to test a curl running
on a remote host. on a remote host.

1
RELEASE-NOTES
View File

@ -18,6 +18,7 @@ This release includes the following bugfixes:
o curl-config --protocols now properly reports LDAPS, SCP and SFTP o curl-config --protocols now properly reports LDAPS, SCP and SFTP
o ldapv3 support on Windows o ldapv3 support on Windows
o ldap builds with the MSVC makefiles o ldap builds with the MSVC makefiles
o no HOME and no key given caused SSH auth failure
This release includes the following known bugs: This release includes the following known bugs:

6
lib/ssh.c
View File

@ -407,6 +407,9 @@ static CURLcode ssh_statemach_act(struct connectdata *conn)
sshc->rsa_pub = aprintf("%s", data->set.str[STRING_SSH_PUBLIC_KEY]); sshc->rsa_pub = aprintf("%s", data->set.str[STRING_SSH_PUBLIC_KEY]);
else if (home) else if (home)
sshc->rsa_pub = aprintf("%s/.ssh/id_dsa.pub", home); sshc->rsa_pub = aprintf("%s/.ssh/id_dsa.pub", home);
else
/* as a final resort, try current dir! */
sshc->rsa_pub = strdup("id_dsa.pub");
if (sshc->rsa_pub == NULL) { if (sshc->rsa_pub == NULL) {
Curl_safefree(home); Curl_safefree(home);
@ -420,6 +423,9 @@ static CURLcode ssh_statemach_act(struct connectdata *conn)
sshc->rsa = aprintf("%s", data->set.str[STRING_SSH_PRIVATE_KEY]); sshc->rsa = aprintf("%s", data->set.str[STRING_SSH_PRIVATE_KEY]);
else if (home) else if (home)
sshc->rsa = aprintf("%s/.ssh/id_dsa", home); sshc->rsa = aprintf("%s/.ssh/id_dsa", home);
else
/* as a final resort, try current dir! */
sshc->rsa = strdup("id_dsa");
if (sshc->rsa == NULL) { if (sshc->rsa == NULL) {
Curl_safefree(home); Curl_safefree(home);