1
0
mirror of https://github.com/moparisthebest/curl synced 2024-12-21 23:58:49 -05:00

cmake: disable tests and man generation if perl/nroff not found

Fixes https://github.com/curl/curl/issues/1500
Reported-by: Jay Satiro

Fixes https://github.com/curl/curl/pull/1662
Assisted-by: Tom Seddon
Assisted-by: dpull@users.noreply.github.com
Assisted-by: elelel@users.noreply.github.com

Closes https://github.com/curl/curl/pull/1924
This commit is contained in:
Sergei Nikulov 2017-09-26 10:42:12 +03:00 committed by Jay Satiro
parent 753a5da906
commit 440dbcb06e
2 changed files with 47 additions and 32 deletions

View File

@ -93,3 +93,32 @@ macro(CURL_INTERNAL_TEST_RUN CURL_TEST)
endif(${CURL_TEST}_COMPILE AND NOT ${CURL_TEST}) endif(${CURL_TEST}_COMPILE AND NOT ${CURL_TEST})
endif() endif()
endmacro(CURL_INTERNAL_TEST_RUN) endmacro(CURL_INTERNAL_TEST_RUN)
macro(CURL_NROFF_CHECK)
find_program(NROFF NAMES gnroff nroff)
if(NROFF)
# Need a way to write to stdin, this will do
file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/nroff-input.txt" "test")
# Tests for a valid nroff option to generate a manpage
foreach(_MANOPT "-man" "-mandoc")
execute_process(COMMAND "${NROFF}" ${_MANOPT}
OUTPUT_VARIABLE NROFF_MANOPT_OUTPUT
INPUT_FILE "${CMAKE_CURRENT_BINARY_DIR}/nroff-input.txt"
ERROR_QUIET)
# Save the option if it was valid
if(NROFF_MANOPT_OUTPUT)
message("Found *nroff option: -- ${_MANOPT}")
set(NROFF_MANOPT ${_MANOPT})
set(NROFF_USEFUL ON)
break()
endif()
endforeach()
# No need for the temporary file
file(REMOVE "${CMAKE_CURRENT_BINARY_DIR}/nroff-input.txt")
if(NOT NROFF_USEFUL)
message(WARNING "Found no *nroff option to get plaintext from man pages")
endif()
else()
message(WARNING "Found no *nroff program")
endif()
endmacro(CURL_NROFF_CHECK)

View File

@ -203,38 +203,20 @@ if(ENABLE_IPV6 AND NOT WIN32)
endif() endif()
endif() endif()
option(ENABLE_MANUAL "to provide the built-in manual" ON) CURL_NROFF_CHECK()
unset(USE_MANUAL CACHE) # TODO: cache NROFF/NROFF_MANOPT/USE_MANUAL vars? find_package(Perl)
if(ENABLE_MANUAL)
find_program(NROFF NAMES gnroff nroff) CMAKE_DEPENDENT_OPTION(ENABLE_MANUAL "to provide the built-in manual"
if(NROFF) ON "NROFF_USEFUL;PERL_FOUND"
# Need a way to write to stdin, this will do OFF)
file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/nroff-input.txt" "test")
# Tests for a valid nroff option to generate a manpage if(NOT PERL_FOUND)
foreach(_MANOPT "-man" "-mandoc") message(STATUS "Perl not found, testing disabled.")
execute_process(COMMAND "${NROFF}" ${_MANOPT} set(BUILD_TESTING OFF)
OUTPUT_VARIABLE NROFF_MANOPT_OUTPUT endif()
INPUT_FILE "${CMAKE_CURRENT_BINARY_DIR}/nroff-input.txt" if(ENABLE_MANUAL)
ERROR_QUIET) set(USE_MANUAL ON)
# Save the option if it was valid
if(NROFF_MANOPT_OUTPUT)
message("Found *nroff option: -- ${_MANOPT}")
set(NROFF_MANOPT ${_MANOPT})
set(USE_MANUAL 1)
break()
endif()
endforeach()
# No need for the temporary file
file(REMOVE "${CMAKE_CURRENT_BINARY_DIR}/nroff-input.txt")
if(NOT USE_MANUAL)
message(WARNING "Found no *nroff option to get plaintext from man pages")
endif()
else()
message(WARNING "Found no *nroff program")
endif()
endif() endif()
# Required for building manual, docs, tests
find_package(Perl REQUIRED)
# We need ansi c-flags, especially on HP # We need ansi c-flags, especially on HP
set(CMAKE_C_FLAGS "${CMAKE_ANSI_CFLAGS} ${CMAKE_C_FLAGS}") set(CMAKE_C_FLAGS "${CMAKE_ANSI_CFLAGS} ${CMAKE_C_FLAGS}")
@ -1149,8 +1131,12 @@ function(TRANSFORM_MAKEFILE_INC INPUT_FILE OUTPUT_FILE)
endfunction() endfunction()
add_subdirectory(docs) if(USE_MANUAL)
add_subdirectory(docs)
endif()
add_subdirectory(lib) add_subdirectory(lib)
if(BUILD_CURL_EXE) if(BUILD_CURL_EXE)
add_subdirectory(src) add_subdirectory(src)
endif() endif()