From 2dded8fedba49b7542a07c78624890dcf9e9dca7 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 23 Dec 2010 14:36:07 +0100 Subject: [PATCH] ossl_seed: no more RAND_screen RAND_screen() is slow, not thread-safe and not needed anymore since OpenSSL uses the thread-safe win32 CryptoAPI nowadays. --- lib/ssluse.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/ssluse.c b/lib/ssluse.c index d8f776018..9e3fca392 100644 --- a/lib/ssluse.c +++ b/lib/ssluse.c @@ -225,7 +225,8 @@ static int ossl_seed(struct SessionHandle *data) /* If we get here, it means we need to seed the PRNG using a "silly" approach! */ #ifdef HAVE_RAND_SCREEN - /* if RAND_screen() is present, it was called during global init */ + /* if RAND_screen() is present, this is windows and thus we assume that the + randomness is already taken care of */ nread = 100; /* just a value */ #else { @@ -685,13 +686,6 @@ int Curl_ossl_init(void) OpenSSL_add_all_algorithms(); -#ifdef HAVE_RAND_SCREEN - /* This one gets a random value by reading the currently shown screen. - RAND_screen() is not thread-safe according to OpenSSL devs - although not - mentioned in documentation. */ - RAND_screen(); -#endif - return 1; }