1
0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00

ares_query_completed_cb: don't touch invalid data

When this callback is called due to the destruction of the ares handle,
the connection pointer passed in as an argument may no longer pointing
to valid data and this function doesn't need to do anything with it
anyway so we make sure it doesn't.

Bug: http://curl.haxx.se/mail/lib-2011-01/0333.html
Reported by: Vsevolod Novikov
This commit is contained in:
Daniel Stenberg 2011-01-27 13:59:11 +01:00
parent dc0a7161f8
commit 2d356ba168

View File

@ -332,8 +332,17 @@ static void ares_query_completed_cb(void *arg, /* (struct connectdata *) */
(void)timeouts; /* ignored */
#endif
if (status == CURL_ASYNC_SUCCESS) {
switch(status) {
case CURL_ASYNC_SUCCESS:
ai = Curl_he2ai(hostent, conn->async.port);
break;
case ARES_EDESTRUCTION:
/* this ares handle is getting destroyed, the 'arg' pointer may not be
valid! */
return;
default:
/* do nothing */
break;
}
(void)Curl_addrinfo_callback(arg, status, ai);