moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Code Issues Releases Wiki Activity

smtp: Fixed response code parsing for bad AUTH continuation responses

Browse Source 
This workaround had been previously been implemented for IMAP and POP3
but not SMTP. Some of the recent test case additions implemented this
behaviour to emulate a bad server and the SMTP code didn't cope with it.
This commit is contained in:
Steve Holme 2013-10-26 11:09:31 +01:00
parent bdb1f0e53d
commit 2766262a68
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/smtp.c
View File

@ -234,8 +234,11 @@ static bool smtp_endofresp(struct connectdata *conn, char *line, size_t len,
if(len < 4 || !ISDIGIT(line[0]) || !ISDIGIT(line[1]) || !ISDIGIT(line[2]))
return FALSE; /* Nothing for us */
/* Do we have a command response? */
result = (line[3] == ' ') ? TRUE : FALSE;
/* Do we have a command response? This should be the response code followed
by a space and optionally some text as per RFC-5321 and as outlined in
Section 4. Examples of RFC-4954 but some e-mail servers ignore this and
only send the response code instead. */
result = (line[3] == ' ' || len == 5) ? TRUE : FALSE;
if(result)
*resp = curlx_sltosi(strtol(line, NULL, 10));