From 231b23acbba2d40265db8843853cc93ab1da2b9b Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Fri, 3 Jan 2014 12:02:56 +0100 Subject: [PATCH] pipeline: remove print_pipeline() This is a debug function only and serves no purpose in production code, it only slows things down. I left the code #ifdef'ed for possible future pipeline debugging. Also, this was a global function without proper namespace usage. Reported-by: He Qin Bug: http://curl.haxx.se/bug/view.cgi?id=1320 --- lib/pipeline.c | 8 ++++++-- lib/pipeline.h | 4 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/pipeline.c b/lib/pipeline.c index 3866597e1..61b8c9697 100644 --- a/lib/pipeline.c +++ b/lib/pipeline.c @@ -6,7 +6,7 @@ * \___|\___/|_| \_\_____| * * Copyright (C) 2013, Linus Nielsen Feltzing, - * Copyright (C) 2013, Daniel Stenberg, , et al. + * Copyright (C) 2013-2014, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -118,7 +118,9 @@ CURLcode Curl_add_handle_to_pipeline(struct SessionHandle *handle, Curl_expire(conn->send_pipe->head->ptr, 1); } +#if 0 /* enable for pipeline debugging */ print_pipeline(conn); +#endif return rc; } @@ -309,7 +311,7 @@ CURLMcode Curl_pipeline_set_server_blacklist(char **servers, return CURLM_OK; } - +#if 0 void print_pipeline(struct connectdata *conn) { struct curl_llist_element *curr; @@ -331,3 +333,5 @@ void print_pipeline(struct connectdata *conn) } } } + +#endif diff --git a/lib/pipeline.h b/lib/pipeline.h index 1df958953..96c4c33ec 100644 --- a/lib/pipeline.h +++ b/lib/pipeline.h @@ -7,7 +7,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 2013, Linus Nielsen Feltzing, + * Copyright (C) 2013 - 2014, Linus Nielsen Feltzing, * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -41,6 +41,4 @@ bool Curl_pipeline_server_blacklisted(struct SessionHandle *handle, CURLMcode Curl_pipeline_set_server_blacklist(char **servers, struct curl_llist **list_ptr); -void print_pipeline(struct connectdata *conn); - #endif /* HEADER_CURL_PIPELINE_H */