moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-24 17:18:48 -05:00
Code Issues Releases Wiki Activity

url: make sure an HSTS upgrade updates URL and scheme correctly

Browse Source 
Closes #6175
This commit is contained in:
Daniel Stenberg 2020-11-05 09:18:52 +01:00
parent f7e72f4d5c
commit 20558ff269
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/url.c
View File

@ -1922,8 +1922,26 @@ static CURLcode parseurlandfillconn(struct Curl_easy *data,
#ifdef USE_HSTS #ifdef USE_HSTS
if(data->hsts && strcasecompare("http", data->state.up.scheme)) { if(data->hsts && strcasecompare("http", data->state.up.scheme)) {
if(Curl_hsts(data->hsts, data->state.up.hostname, TRUE)) if(Curl_hsts(data->hsts, data->state.up.hostname, TRUE)) {
infof(data, "Switch from HTTP to HTTPS due to HSTS!\n"); char *url;
Curl_safefree(data->state.up.scheme);
uc = curl_url_set(uh, CURLUPART_SCHEME, "https", 0);
if(uc)
return Curl_uc_to_curlcode(uc);
if(data->change.url_alloc)
Curl_safefree(data->change.url);
/* after update, get the updated version */
uc = curl_url_get(uh, CURLUPART_URL, &url, 0);
if(uc)
return Curl_uc_to_curlcode(uc);
uc = curl_url_get(uh, CURLUPART_SCHEME, &data->state.up.scheme, 0);
if(uc)
return Curl_uc_to_curlcode(uc);
data->change.url = url;
data->change.url_alloc = TRUE;
infof(data, "Switched from HTTP to HTTPS due to HSTS => %s\n",
data->change.url);
}
} }
#endif #endif