From 1ff1d9e179bb2a5b55d1323f9a74ccec361437b1 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 1 Jul 2021 00:21:43 +0200 Subject: [PATCH] lib: more %u for port and int for %*s fixes Detected by Coverity Closes #7329 --- lib/connect.c | 2 +- lib/vtls/openssl.c | 2 +- lib/x509asn1.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/connect.c b/lib/connect.c index 1875334d6..b413db843 100644 --- a/lib/connect.c +++ b/lib/connect.c @@ -980,7 +980,7 @@ CURLcode Curl_is_connected(struct Curl_easy *data, char buffer[STRERROR_LEN]; Curl_printable_address(conn->tempaddr[i], ipaddress, sizeof(ipaddress)); - infof(data, "connect to %s port %ld failed: %s\n", + infof(data, "connect to %s port %u failed: %s\n", ipaddress, conn->port, Curl_strerror(error, buffer, sizeof(buffer))); #endif diff --git a/lib/vtls/openssl.c b/lib/vtls/openssl.c index 63b9745a8..1ccf6da36 100644 --- a/lib/vtls/openssl.c +++ b/lib/vtls/openssl.c @@ -3868,7 +3868,7 @@ static CURLcode servercert(struct Curl_easy *data, long len; ASN1_TIME_print(mem, X509_get0_notBefore(backend->server_cert)); len = BIO_get_mem_data(mem, (char **) &ptr); - infof(data, " start date: %.*s\n", len, ptr); + infof(data, " start date: %.*s\n", (int)len, ptr); (void)BIO_reset(mem); ASN1_TIME_print(mem, X509_get0_notAfter(backend->server_cert)); diff --git a/lib/x509asn1.c b/lib/x509asn1.c index acd39a4ed..1c1b9e1d2 100644 --- a/lib/x509asn1.c +++ b/lib/x509asn1.c @@ -517,7 +517,7 @@ static const char *GTime2str(const char *beg, const char *end) return curl_maprintf("%.4s-%.2s-%.2s %.2s:%.2s:%c%c%s%.*s%s%.*s", beg, beg + 4, beg + 6, beg + 8, beg + 10, sec1, sec2, - fracl? ".": "", fracl, fracp, + fracl? ".": "", (int)fracl, fracp, sep, (int)tzl, tzp); }