moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2025-02-28 09:21:50 -05:00
Code Issues Releases Wiki Activity

*_sspi: fix bad uses of CURLE_NOT_BUILT_IN

Browse Source 
Return CURLE_AUTH_ERROR instead of CURLE_NOT_BUILT_IN for other
instances of QuerySecurityPackageInfo failing, as in
commit 2a81439553286f12cd04a4bdcdf66d8e026d8201.

Closes #5355
This commit is contained in:
Peter Wang 2020-05-08 10:43:45 +10:00 committed by Daniel Stenberg
parent ace6ae4d0e
commit 1c341e2270
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/vauth/digest_sspi.c
View File

@ -134,7 +134,8 @@ CURLcode Curl_auth_create_digest_md5_message(struct Curl_easy *data,
if(status != SEC_E_OK) {
free(input_token);
return CURLE_NOT_BUILT_IN;
failf(data, "SSPI: couldn't get auth info\n");
return CURLE_AUTH_ERROR;
}
token_max = SecurityPackage->cbMaxToken;
@ -431,8 +432,10 @@ CURLcode Curl_auth_create_digest_http_message(struct Curl_easy *data,
/* Query the security package for DigestSSP */
status = s_pSecFn->QuerySecurityPackageInfo((TCHAR *) TEXT(SP_NAME_DIGEST),
&SecurityPackage);
if(status != SEC_E_OK)
return CURLE_NOT_BUILT_IN;
if(status != SEC_E_OK) {
failf(data, "SSPI: couldn't get auth info\n");
return CURLE_AUTH_ERROR;
}
token_max = SecurityPackage->cbMaxToken;

3
lib/vauth/krb5_sspi.c
View File

@ -125,7 +125,8 @@ CURLcode Curl_auth_create_gssapi_user_message(struct Curl_easy *data,
TEXT(SP_NAME_KERBEROS),
&SecurityPackage);
if(status != SEC_E_OK) {
return CURLE_NOT_BUILT_IN;
failf(data, "SSPI: couldn't get auth info\n");
return CURLE_AUTH_ERROR;
}
krb5->token_max = SecurityPackage->cbMaxToken;

6
lib/vauth/spnego_sspi.c
View File

@ -129,8 +129,10 @@ CURLcode Curl_auth_decode_spnego_message(struct Curl_easy *data,
nego->status = s_pSecFn->QuerySecurityPackageInfo((TCHAR *)
TEXT(SP_NAME_NEGOTIATE),
&SecurityPackage);
if(nego->status != SEC_E_OK)
return CURLE_NOT_BUILT_IN;
if(nego->status != SEC_E_OK) {
failf(data, "SSPI: couldn't get auth info\n");
return CURLE_AUTH_ERROR;
}
nego->token_max = SecurityPackage->cbMaxToken;