moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-21 23:58:49 -05:00
Code Issues Releases Wiki Activity

"Ofer" reported a problem when libcurl re-used a connection and failed to do

Browse Source 
it, it could then accidentally actually crash. Presumably, this concerns FTP
connections.  http://curl.haxx.se/bug/view.cgi?id=1330310
This commit is contained in:
Daniel Stenberg 2005-10-21 21:00:44 +00:00
parent 715b706caa
commit 1a1ab2e2e8
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES
View File

@ -9,6 +9,10 @@
Daniel (21 October 2005) Daniel (21 October 2005)
- "Ofer" reported a problem when libcurl re-used a connection and failed to do
it, it could then accidentally actually crash. Presumably, this concerns FTP
connections. http://curl.haxx.se/bug/view.cgi?id=1330310
- Temprimus improved the MSVC makefile so that the static debug SSL libs are - Temprimus improved the MSVC makefile so that the static debug SSL libs are
linked to the executable and not to the libcurld.lib linked to the executable and not to the libcurld.lib
http://curl.haxx.se/bug/view.cgi?id=1326676 http://curl.haxx.se/bug/view.cgi?id=1326676

9
lib/url.c
View File

@ -3844,7 +3844,14 @@ CURLcode Curl_do(struct connectdata **connp, bool *done)
/* conn may no longer be a good pointer */ /* conn may no longer be a good pointer */
if(CURLE_OK == result) { /*
* According to bug report #1330310. We need to check for
* CURLE_SEND_ERROR here as well. I figure this could happen when the
* request failed on a FTP connection and thus Curl_done() itself tried
* to use the connection (again). Slight Lack of feedback in the report,
* but I don't think this extra check can do much harm.
*/
if((CURLE_OK == result) || (CURLE_SEND_ERROR == result)) {
bool async; bool async;
bool protocol_done = TRUE; bool protocol_done = TRUE;