moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Code Issues Releases Wiki Activity

netrc: free 'home' on error

Browse Source 
Follow-up to f9c7ba9096

Coverity CID 1453474

Closes #4291
This commit is contained in:
Daniel Stenberg 2019-09-03 13:46:36 +02:00
parent 4ac2884003
commit 158dcb9f86
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/netrc.c
View File

@ -218,8 +218,10 @@ int Curl_parsenetrc(const char *host,
char *filealloc = NULL;
if(!netrcfile) {
char *home = curl_getenv("HOME"); /* portable environment reader */
if(home) {
char *home = NULL;
char *homea = curl_getenv("HOME"); /* portable environment reader */
if(homea) {
home = homea;
#if defined(HAVE_GETPWUID_R) && defined(HAVE_GETEUID)
}
else {
@ -227,9 +229,7 @@ int Curl_parsenetrc(const char *host,
char pwbuf[1024];
if(!getpwuid_r(geteuid(), &pw, pwbuf, sizeof(pwbuf), &pw_res)
&& pw_res) {
home = strdup(pw.pw_dir);
if(!home)
return -1;
home = pw.pw_dir;
}
#elif defined(HAVE_GETPWUID) && defined(HAVE_GETEUID)
}
@ -247,8 +247,10 @@ int Curl_parsenetrc(const char *host,
memory) */
filealloc = curl_maprintf("%s%s.netrc", home, DIR_CHAR);
if(!filealloc)
if(!filealloc) {
free(homea);
return -1;
}
retcode = parsenetrc(host, loginp, passwordp, login_changed,
password_changed, filealloc);
free(filealloc);
@ -256,13 +258,16 @@ int Curl_parsenetrc(const char *host,
if(retcode == NETRC_FILE_MISSING) {
/* fallback to the old-style "_netrc" file */
filealloc = curl_maprintf("%s%s_netrc", home, DIR_CHAR);
if(!filealloc)
if(!filealloc) {
free(homea);
return -1;
}
retcode = parsenetrc(host, loginp, passwordp, login_changed,
password_changed, filealloc);
free(filealloc);
}
#endif
free(homea);
}
else
retcode = parsenetrc(host, loginp, passwordp, login_changed,