moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-23 16:48:49 -05:00
Code Issues Releases Wiki Activity

file: avoid duplicated code sequence

Browse Source 
file_disconnect() is identical with file_do() except the function header
but as the arguments are unused anyway so why not just return file_do()
directly!

Reviewed-by: Daniel Stenberg
Closes #6249
This commit is contained in:
Emil Engler 2020-11-25 18:26:56 +01:00 committed by Daniel Stenberg
parent 920f49a20b
commit 12cb7a1fe0
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/file.c
View File

@ -227,18 +227,8 @@ static CURLcode file_done(struct connectdata *conn,
static CURLcode file_disconnect(struct connectdata *conn, static CURLcode file_disconnect(struct connectdata *conn,
bool dead_connection) bool dead_connection)
{ {
struct FILEPROTO *file = conn->data->req.p.file;
(void)dead_connection; /* not used */ (void)dead_connection; /* not used */
return file_done(conn, 0, 0);
if(file) {
Curl_safefree(file->freepath);
file->path = NULL;
if(file->fd != -1)
close(file->fd);
file->fd = -1;
}
return CURLE_OK;
} }
#ifdef DOS_FILESYSTEM #ifdef DOS_FILESYSTEM