moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-11-11 03:55:03 -05:00
Code Issues Releases Wiki Activity

- Bug report #2416182 titled "crash in ConnectionExists when using

Browse Source 
duphandle+curl_mutli" (http://curl.haxx.se/bug/view.cgi?id=2416182) showed
  that curl_easy_duphandle() wrongly also copied the pointer to the connection
  cache, which was plain wrong and caused a segfault if the handle would be
  used in a different multi handle than the handle it was duplicated from.
This commit is contained in:
Daniel Stenberg 2008-12-11 23:52:56 +00:00
parent c0dfe6e51d
commit 0f5895faee
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGES
View File

@ -6,6 +6,13 @@
Changelog Changelog
Daniel Stenberg (12 Dec 2008)
- Bug report #2416182 titled "crash in ConnectionExists when using
duphandle+curl_mutli" (http://curl.haxx.se/bug/view.cgi?id=2416182) showed
that curl_easy_duphandle() wrongly also copied the pointer to the connection
cache, which was plain wrong and caused a segfault if the handle would be
used in a different multi handle than the handle it was duplicated from.
Daniel Stenberg (11 Dec 2008) Daniel Stenberg (11 Dec 2008)
- Keshav Krity found out that libcurl failed to deal with dotted IPv6 - Keshav Krity found out that libcurl failed to deal with dotted IPv6
addresses if they were very long (>39 letters) due to a too strict address addresses if they were very long (>39 letters) due to a too strict address

1
RELEASE-NOTES
View File

@ -28,6 +28,7 @@ This release includes the following bugfixes:
o 550 response from SIZE no longer treated as missing file o 550 response from SIZE no longer treated as missing file
o ftps:// control connections now use explicit protection level o ftps:// control connections now use explicit protection level
o dotted IPv6 addresses longer than 39 bytes failed o dotted IPv6 addresses longer than 39 bytes failed
o curl_easy_duphandle() doesn't try to duplicate the connection cache pointer
This release includes the following known bugs: This release includes the following known bugs:

9
lib/easy.c
View File

@ -624,13 +624,8 @@ CURL *curl_easy_duphandle(CURL *incurl)
if(Curl_dupset(outcurl, data) != CURLE_OK) if(Curl_dupset(outcurl, data) != CURLE_OK)
break; break;
if(data->state.used_interface == Curl_if_multi) /* the connection cache is setup on demand */
outcurl->state.connc = data->state.connc; outcurl->state.connc = NULL;
else
outcurl->state.connc = Curl_mk_connc(CONNCACHE_PRIVATE, -1);
if(!outcurl->state.connc)
break;
outcurl->state.lastconnect = -1; outcurl->state.lastconnect = -1;