moparisthebest
/
curl
mirror of https://github.com/moparisthebest/curl
1
0
Fork 0
Code Issues Releases Wiki Activity

added a NULL pointer check for the name field as it can in fact be NULL when 

dereferenced here, if the app passes in a funny combo. Detected by coverity.com
This commit is contained in:
Daniel Stenberg 2008-10-20 21:56:35 +00:00
parent 231a51fe7a
commit 0bb91218c5
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/formdata.c
View File

@ -743,8 +743,11 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
}
if( !(form->flags & HTTPPOST_PTRNAME) &&
(form == first_form) ) {
/* copy name (without strdup; possibly contains null characters) */
form->name = memdup(form->name, form->namelength);
/* Note that there's small risk that form->name is NULL here if the
app passed in a bad combo, so we better check for that first. */
if(form->name)
/* copy name (without strdup; possibly contains null characters) */
form->name = memdup(form->name, form->namelength);
if(!form->name) {
return_value = CURL_FORMADD_MEMORY;
break;