mirror of https://github.com/moparisthebest/curl
Dmitry Kurochkin mentioned a flaw
(http://curl.haxx.se/mail/lib-2007-12/0252.html) in detect_proxy() which failed to set the bits.proxy variable properly when an environment variable told libcurl to use a http proxy.
This commit is contained in:
parent
f277124a0f
commit
04e4d9a0b3
6
CHANGES
6
CHANGES
|
@ -6,6 +6,12 @@
|
||||||
|
|
||||||
Changelog
|
Changelog
|
||||||
|
|
||||||
|
Daniel S (27 Dec 2007)
|
||||||
|
- Dmitry Kurochkin mentioned a flaw
|
||||||
|
(http://curl.haxx.se/mail/lib-2007-12/0252.html) in detect_proxy() which
|
||||||
|
failed to set the bits.proxy variable properly when an environment variable
|
||||||
|
told libcurl to use a http proxy.
|
||||||
|
|
||||||
Daniel S (26 Dec 2007)
|
Daniel S (26 Dec 2007)
|
||||||
- In an attempt to repeat the problem in bug report #1850730
|
- In an attempt to repeat the problem in bug report #1850730
|
||||||
(http://curl.haxx.se/bug/view.cgi?id=1850730) I wrote up test case 552. The
|
(http://curl.haxx.se/bug/view.cgi?id=1850730) I wrote up test case 552. The
|
||||||
|
|
|
@ -39,6 +39,7 @@ This release includes the following bugfixes:
|
||||||
o build fix for MSVC 9.0 (VS2008)
|
o build fix for MSVC 9.0 (VS2008)
|
||||||
o Windows curl builds failed file truncation when retry downloading
|
o Windows curl builds failed file truncation when retry downloading
|
||||||
o SSL session ID cache memory leak
|
o SSL session ID cache memory leak
|
||||||
|
o bad connection re-use check with environment variable-activated proxy use
|
||||||
|
|
||||||
This release includes the following known bugs:
|
This release includes the following known bugs:
|
||||||
|
|
||||||
|
@ -59,6 +60,7 @@ advice from friends like these:
|
||||||
Dan Fandrich, Gisle Vanem, Toby Peterson, Yang Tse, Daniel Black,
|
Dan Fandrich, Gisle Vanem, Toby Peterson, Yang Tse, Daniel Black,
|
||||||
Robin Johnson, Michal Marek, Ates Goral, Andres Garcia, Rob Crittenden,
|
Robin Johnson, Michal Marek, Ates Goral, Andres Garcia, Rob Crittenden,
|
||||||
Emil Romanus, Alessandro Vesely, Ray Pekowski, Spacen Jasset, Andrew Moise,
|
Emil Romanus, Alessandro Vesely, Ray Pekowski, Spacen Jasset, Andrew Moise,
|
||||||
Gilles Blanc, David Wright, Vikram Saxena, Mateusz Loskot, Gary Maxwell
|
Gilles Blanc, David Wright, Vikram Saxena, Mateusz Loskot, Gary Maxwell,
|
||||||
|
Dmitry Kurochkin
|
||||||
|
|
||||||
Thanks! (and sorry if I forgot to mention someone)
|
Thanks! (and sorry if I forgot to mention someone)
|
||||||
|
|
|
@ -3242,7 +3242,7 @@ static char *detect_proxy(struct connectdata *conn)
|
||||||
if(conn->proxytype == CURLPROXY_HTTP) {
|
if(conn->proxytype == CURLPROXY_HTTP) {
|
||||||
/* force this connection's protocol to become HTTP */
|
/* force this connection's protocol to become HTTP */
|
||||||
conn->protocol = PROT_HTTP | bits;
|
conn->protocol = PROT_HTTP | bits;
|
||||||
conn->bits.httpproxy = TRUE;
|
conn->bits.proxy = conn->bits.httpproxy = TRUE;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
} /* if(!nope) - it wasn't specified non-proxy */
|
} /* if(!nope) - it wasn't specified non-proxy */
|
||||||
|
|
Loading…
Reference in New Issue