moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2025-02-28 09:21:50 -05:00
Code Issues Releases Wiki Activity

openssl: remove outdated comment

Browse Source 
OpenSSL used to call exit(1) on syntax errors in OPENSSL_config(),
which is why we switched to CONF_modules_load_file() and introduced
a comment stating why. This behavior was however changed in OpenSSL
commit abdd677125f3a9e3082f8c5692203590fdb9b860, so remove the now
outdated and incorrect comment. The mentioned commit also declares
OPENSSL_config() deprecated so keep the current coding.

Closes #4033
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
This commit is contained in:
Daniel Gustafsson 2019-06-17 13:11:02 +02:00
parent 4b1e7dd4ee
commit 03a22a26c6
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/vtls/openssl.c
View File

@ -1022,14 +1022,8 @@ static int Curl_ossl_init(void)
ENGINE_load_builtin_engines(); ENGINE_load_builtin_engines();
#endif #endif
/* OPENSSL_config(NULL); is "strongly recommended" to use but unfortunately /* CONF_MFLAGS_DEFAULT_SECTION was introduced some time between 0.9.8b and
that function makes an exit() call on wrongly formatted config files 0.9.8e */
which makes it hard to use in some situations. OPENSSL_config() itself
calls CONF_modules_load_file() and we use that instead and we ignore
its return code! */
/* CONF_MFLAGS_DEFAULT_SECTION introduced some time between 0.9.8b and
0.9.8e */
#ifndef CONF_MFLAGS_DEFAULT_SECTION #ifndef CONF_MFLAGS_DEFAULT_SECTION
#define CONF_MFLAGS_DEFAULT_SECTION 0x0 #define CONF_MFLAGS_DEFAULT_SECTION 0x0
#endif #endif