moparisthebest
/
curl
mirror of https://github.com/moparisthebest/curl
1
0
Fork 0
Code Issues Releases Wiki Activity

Dirk Manske made the share-locking around DNS lookups a bit "looser" so that 

multiple DNS lookups can run simultaneously faster. The downside is that
resolving the same host name now can be made at once from multiple threads,
but the upside is that threads now don't alwys have to wait for the others'
resolves. Test case 506 updated accordingly.
This commit is contained in:
Daniel Stenberg 2003-10-12 13:57:41 +00:00
parent 4935853eb9
commit 022996e5c7
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/hostip.c
View File

@ -307,6 +307,9 @@ int Curl_resolv(struct connectdata *conn,
/* See if its already in our dns cache */
dns = Curl_hash_pick(data->hostcache, entry_id, entry_len+1);
if(data->share)
Curl_share_unlock(data, CURL_LOCK_DATA_DNS);
/* free the allocated entry_id again */
free(entry_id);
@ -332,12 +335,18 @@ int Curl_resolv(struct connectdata *conn,
}
}
else
{
if(data->share)
Curl_share_lock(data, CURL_LOCK_DATA_DNS, CURL_LOCK_ACCESS_SINGLE);
/* we got a response, store it in the cache */
dns = cache_resolv_response(data, addr, hostname, port);
if(data->share)
Curl_share_unlock(data, CURL_LOCK_DATA_DNS);
}
}
if(data->share)
Curl_share_unlock(data, CURL_LOCK_DATA_DNS);
*entry = dns;

2
tests/data/test506
View File

@ -68,6 +68,8 @@ unlock: share <Pigs in space>
PERFORM
lock: dns <Pigs in space>
unlock: dns <Pigs in space>
lock: dns <Pigs in space>
unlock: dns <Pigs in space>
lock: cookie <Pigs in space>
unlock: cookie <Pigs in space>
lock: cookie <Pigs in space>