moparisthebest/beehive
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Close context in a finally

Browse Source
This commit is contained in:
Travis Burtrum 2017-04-20 10:28:32 -04:00
parent a7e159b172
commit 6bcb3d0039
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
beehive-jdbc-mapper/src/main/java/com/moparisthebest/jdbc/QueryMapper.java
View File

@ -33,15 +33,16 @@ public class QueryMapper implements Closeable {
this.cm = cm == null ? new ResultSetMapper() : cm; this.cm = cm == null ? new ResultSetMapper() : cm;
Context context = null; Context context = null;
if (conn == null && jndiName != null) if (conn == null && jndiName != null)
try { try {
context = new InitialContext(); context = new InitialContext();
DataSource ds = (DataSource) context.lookup(jndiName); DataSource ds = (DataSource) context.lookup(jndiName);
conn = ds.getConnection(); conn = ds.getConnection();
} catch (Throwable e) { } catch (Throwable e) {
e.printStackTrace(); e.printStackTrace();
tryClose(conn); tryClose(conn);
tryClose(context); } finally {
} tryClose(context);
}
this.conn = conn; this.conn = conn;
this.context = context; this.context = context;
if (this.conn == null) if (this.conn == null)