mirror of
https://github.com/moparisthebest/Yaaic
synced 2024-11-25 10:22:16 -05:00
ffe73b7c9f
There are at least two significant memory leaks in Yaaic, which cause the client to force close after a few hours with an OutOfMemoryException: (1) The IRCService holds Conversation objects, which contain a MessageListAdapter, which have references to the ConversationActivity context. This causes Activity contexts to outlast the Activity, causing a significant memory leak over time. Fix this by holding the MessageListAdapter in the ConversationActivity's DeckAdapter instead of in the Conversation objects. The DeckAdapter's lifecycle matches that of the Activity, so this prevents the leak. (2) Every call to DeckAdapter.getView()/renderConversation() creates a new MessageListView and adds it to the deck. But adding the view to the deck causes the deck to take a reference to the view, leaking the MessageListView until the Activity is finished. (This has the effect of exacerbating the first leak, since the Activity context holds a reference to the deck.) Fix this leak by caching MessageListViews in the DeckAdapter, and returning an existing MessageListView for a Conversation in getView() if one already exists. |
||
|---|---|---|
| application | ||
| test | ||
| tools | ||
| .gitignore | ||
| build.conf.sample | ||
| CHANGELOG | ||
| CONTRIBUTORS | ||
| LICENCE | ||
| README | ||
| release.sh | ||
| test.sh | ||
Yaaic - Yet Another Android IRC Client Yaaic is as the full name already says an Internet Relay Chat (IRC) client for Android devices. -------------------------------------------------------------------- This is the source code distribution of Yaaic. If you are looking for a compiled 'ready to use' version (APK), see the official homepage at: http://www.yaaic.org Yaaic is also avaiable at the official Android market. If you are a developer and want to contribute to Yaaic, checkout our repository at github: http://github.com/pocmo/Yaaic The application project is located in application/ while the test/ folder contains unit and scenario tests. (Both folders are two separate eclipse projects!) Drop me a line for questions regarding Yaaic or use one of the following ressources: IRC: irc.epd-me.net #yaaic Homepage: http://www.yaaic.org Google Group: http://groups.google.com/group/yaaic/ Twitter: http://twitter.com/Yaaic Facebook: http://www.facebook.com/pages/Yaaic/359902798214 -------------------------------------------------------------------- Yaaic includes the PircBot IRC API written by Paul Mutton available under the GNU General Public License (GPL). http://www.jibble.org The Yaaic icon was designed by http://www.androidicons.com Some icons are part of the Silk icon set designed by Mark James available under the Creative Commons Licence Attribution 3.0 Licence. http://www.famfamfam.com -------------------------------------------------------------------- Copyright 2009-2011 Sebastian Kaspari Yaaic is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. Yaaic is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with Yaaic. If not, see http://www.gnu.org/licenses/