mirror of
https://github.com/moparisthebest/Yaaic
synced 2025-02-27 08:51:56 -05:00
e07d99ed5d
If a conversation disappears while the activity is paused (e.g. if the user is kicked from a channel, or if another client attached to an irssi-proxy has chosen to leave that channel), we currently aren't removing the view from the DeckAdapter when we resume. This results in leaking a Conversation object until the user explicitly asks for the conversation to be closed or the activity finishes, and is also confusing because the user may not receive any indication that the channel was parted in the first place. There's a good case for leaving the MessageListView in place, with a note indicating that the user has been kicked or parted from the channel, but for that to work, we need to keep the Conversation object in the server's list of conversations -- otherwise the behavior will differ depending on whether the user left the activity via the Back button or the Home button, which is counterintuitive. For now, just remove the stale view from the DeckAdapter, which fixes the leak and the potential user confusion.