moparisthebest/Yaaic
1
0
Fork 0
mirror of https://github.com/moparisthebest/Yaaic synced 2024-11-26 19:02:17 -05:00
Code Issues Releases Wiki Activity

Optimization: No getters in loops

Browse Source
This commit is contained in:
Sebastian Kaspari 2010-03-30 21:31:38 +02:00
parent 60f4412096
commit 902b1a5b09
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/org/yaaic/irc/IRCConnection.java
View File

@ -384,8 +384,9 @@ public class IRCConnection extends PircBot
@Override
protected void onNickChange(String oldNick, String login, String hostname, String newNick)
{
// XXX: Optimization : No getter in for loop
for (String target : getChannelsByNickname(newNick)) {
Vector<String> channels = getChannelsByNickname(newNick);
for (String target : channels) {
Message message = new Message(oldNick + " is now known as " + newNick);
message.setColor(Message.COLOR_GREEN);
server.getConversation(target).addMessage(message);
@ -526,8 +527,9 @@ public class IRCConnection extends PircBot
protected void onQuit(String sourceNick, String sourceLogin, String sourceHostname, String reason)
{
if (!sourceNick.equals(this.getNick())) {
// XXX: Optimization : No getter in for loop
for (String target : getChannelsByNickname(sourceNick)) {
Vector<String> channels = getChannelsByNickname(sourceNick);
for (String target : channels) {
Message message = new Message(sourceNick + " quits (" + reason + ")");
message.setColor(Message.COLOR_GREEN);
message.setIcon(R.drawable.quit);
@ -981,11 +983,11 @@ public class IRCConnection extends PircBot
private Vector<String> getChannelsByNickname(String nickname)
{
Vector<String> channels = new Vector<String>();
String[] channelArray = getChannels();
// XXX: Optimization : No getter in for loop
for (String channel : this.getChannels()) {
// XXX: Optimization : No getter in for loop
for (User user : this.getUsers(channel)) {
for (String channel : channelArray) {
User[] userArray = getUsers(channel);
for (User user : userArray) {
if (user.getNick().equals(nickname)) {
channels.add(channel);
break;