moparisthebest
/
Yaaic
mirror of https://github.com/moparisthebest/Yaaic
1
0
Fork 0
Code Issues Releases Wiki Activity

MessageListAdapter: cache field lookups

This commit is contained in:
Sebastian Kaspari 2010-03-21 16:06:52 +01:00
parent e3d13a3880
commit 705ad8c00a
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/org/yaaic/adapter/MessageListAdapter.java
View File

@ -49,8 +49,7 @@ public class MessageListAdapter extends BaseAdapter
*/
public MessageListAdapter(Conversation conversation, Context context)
{
this.messages = new LinkedList<TextView>();
this.context = context;
LinkedList<TextView> messages = new LinkedList<TextView>();
// Render channel name as first message in channel
if (conversation.getType() != Conversation.TYPE_SERVER) {
@ -59,13 +58,20 @@ public class MessageListAdapter extends BaseAdapter
messages.add(header.renderTextView(context));
}
for (int i = 0; i < conversation.getHistorySize(); i++) {
messages.add(conversation.getHistoryMessage(i).renderTextView(context));
// Optimization - cache field lookups
LinkedList<Message> mHistory = conversation.getHistory();
int mSize = mHistory.size();
for (int i = 0; i < mSize; i++) {
messages.add(mHistory.get(i).renderTextView(context));
}
// XXX: We don't want to clear the buffer, we want to add only
// buffered messages that are not already added (history)
conversation.clearBuffer();
this.messages = messages;
this.context = context;
}
/**