moparisthebest/JdbcMapper
1
0
Fork 0
mirror of https://github.com/moparisthebest/JdbcMapper synced 2024-11-25 18:32:18 -05:00
Code Issues Releases Wiki Activity

In JdbcMapper, error out on unused parameters

Browse Source
This commit is contained in:
Travis Burtrum 2017-06-02 01:01:53 -04:00
parent f14b87203a
commit c1139447e4
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
jdbcmapper/src/main/java/com/moparisthebest/jdbc/codegen/JdbcMapperProcessor.java
View File

@ -216,6 +216,7 @@ public class JdbcMapperProcessor extends AbstractProcessor {
if (++count != numParams) if (++count != numParams)
w.write(", "); w.write(", ");
} }
final Map<String, VariableElement> unusedParams = new HashMap<String, VariableElement>(paramMap);
// throws? // throws?
w.write(")"); w.write(")");
@ -242,6 +243,7 @@ public class JdbcMapperProcessor extends AbstractProcessor {
processingEnv.getMessager().printMessage(Diagnostic.Kind.ERROR, String.format("@JdbcMapper.SQL sql has bind param '%s' not in method parameter list", paramName), methodElement); processingEnv.getMessager().printMessage(Diagnostic.Kind.ERROR, String.format("@JdbcMapper.SQL sql has bind param '%s' not in method parameter list", paramName), methodElement);
continue; continue;
} }
unusedParams.remove(paramName);
final String inColumnName = bindParamMatcher.group(2); final String inColumnName = bindParamMatcher.group(2);
if(inColumnName == null) { if(inColumnName == null) {
bindParams.add(bindParam); bindParams.add(bindParam);
@ -270,6 +272,10 @@ public class JdbcMapperProcessor extends AbstractProcessor {
} }
bindParamMatcher.appendTail(sb); bindParamMatcher.appendTail(sb);
sqlStatement = sb.toString(); sqlStatement = sb.toString();
for(final Map.Entry<String, VariableElement> unusedParam : unusedParams.entrySet()) {
processingEnv.getMessager().printMessage(Diagnostic.Kind.ERROR, String.format("@JdbcMapper.SQL method has unused parameter '%s'", unusedParam.getKey()), unusedParam.getValue());
}
} }
final SQLParser parsedSQl = parser.parse(sqlStatement); final SQLParser parsedSQl = parser.parse(sqlStatement);