moparisthebest/JdbcMapper
1
0
Fork 0
mirror of https://github.com/moparisthebest/JdbcMapper synced 2024-11-22 00:52:16 -05:00
Code Issues Releases Wiki Activity

Lazy load SQLChecker so it doesn't error if it won't be used

Browse Source
This commit is contained in:
Travis Burtrum 2019-02-15 11:12:24 -05:00
parent bf7be50d89
commit 7b1b83fddd
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
jdbcmapper/src/main/java/com/moparisthebest/jdbc/codegen/JdbcMapperProcessor.java
View File

@ -72,10 +72,12 @@ public class JdbcMapperProcessor extends AbstractProcessor {
//IFJAVA8_END //IFJAVA8_END
private JdbcMapper.DatabaseType defaultDatabaseType; private JdbcMapper.DatabaseType defaultDatabaseType;
private String defaultArrayNumberTypeName, defaultArrayStringTypeName; private String defaultArrayNumberTypeName, defaultArrayStringTypeName;
private SQLChecker sqlChecker;
private Set<String> allowedMaxRowParamNames; private Set<String> allowedMaxRowParamNames;
private CompileTimeResultSetMapper rsm; private CompileTimeResultSetMapper rsm;
private String sqlCheckerClass;
private SQLChecker sqlChecker;
public JdbcMapperProcessor() { public JdbcMapperProcessor() {
//out.println("JdbcMapperProcessor running!"); //out.println("JdbcMapperProcessor running!");
} }
@ -142,15 +144,8 @@ public class JdbcMapperProcessor extends AbstractProcessor {
defaultArrayStringTypeName = processingEnv.getOptions().get("jdbcMapper.arrayStringTypeName"); defaultArrayStringTypeName = processingEnv.getOptions().get("jdbcMapper.arrayStringTypeName");
if (defaultArrayStringTypeName == null || defaultArrayStringTypeName.isEmpty()) if (defaultArrayStringTypeName == null || defaultArrayStringTypeName.isEmpty())
defaultArrayStringTypeName = defaultDatabaseType.arrayStringTypeName; defaultArrayStringTypeName = defaultDatabaseType.arrayStringTypeName;
final String sqlCheckerClass = processingEnv.getOptions().get("jdbcMapper.sqlCheckerClass");
if(sqlCheckerClass != null) { sqlCheckerClass = processingEnv.getOptions().get("jdbcMapper.sqlCheckerClass");
try {
sqlChecker = (SQLChecker) Class.forName(sqlCheckerClass).newInstance();
} catch (Throwable e) {
processingEnv.getMessager().printMessage(Diagnostic.Kind.ERROR,
"Error instantiating class specified by jdbcMapper.sqlCheckerClass, needs to implement SQLChecker and have a public no-arg constructor:" + toString(e));
}
}
String allowedMaxRowParamNames = processingEnv.getOptions().get("JdbcMapper.allowedMaxRowParamNames"); String allowedMaxRowParamNames = processingEnv.getOptions().get("JdbcMapper.allowedMaxRowParamNames");
if (allowedMaxRowParamNames == null || allowedMaxRowParamNames.isEmpty()) if (allowedMaxRowParamNames == null || allowedMaxRowParamNames.isEmpty())
@ -638,9 +633,21 @@ public class JdbcMapperProcessor extends AbstractProcessor {
w.write("\t}\n"); w.write("\t}\n");
if(sqlChecker != null && eeMethod.getAnnotation(JdbcMapper.SkipSQLCheck.class) == null) if(sqlCheckerClass != null && eeMethod.getAnnotation(JdbcMapper.SkipSQLCheck.class) == null) {
if(sqlChecker == null) {
// *can* this run in parallel? unsure, probably doesn't hurt though
synchronized (this) {
try {
sqlChecker = (SQLChecker) Class.forName(sqlCheckerClass).newInstance();
} catch (Throwable e) {
processingEnv.getMessager().printMessage(Diagnostic.Kind.ERROR,
"Error instantiating class specified by jdbcMapper.sqlCheckerClass, needs to implement SQLChecker and have a public no-arg constructor:" + toString(e), eeMethod);
}
}
}
sqlChecker.checkSql(processingEnv, genClass, mapper, databaseType, eeMethod, sqlStatement, bindParams, arrayInList); sqlChecker.checkSql(processingEnv, genClass, mapper, databaseType, eeMethod, sqlStatement, bindParams, arrayInList);
} }
}
// look on super classes and interfaces recursively // look on super classes and interfaces recursively
if (lookupCloseMethod) if (lookupCloseMethod)