Fix a file handle leak

This commit is contained in:
Sam Whited 2015-07-22 22:21:28 -05:00
parent 7f6be7e97a
commit f397219c27

View File

@ -103,13 +103,12 @@ class HttpHandler(BaseHTTPRequestHandler):
filename = os.path.join(config['storage_path'], path) filename = os.path.join(config['storage_path'], path)
os.makedirs(os.path.dirname(filename)) os.makedirs(os.path.dirname(filename))
remaining = length remaining = length
f = open(filename,'wb') with open(filename,'wb') as f:
data = self.rfile.read(4096) data = self.rfile.read(4096)
while data and remaining >= 0: while data and remaining >= 0:
remaining -= len(data) remaining -= len(data)
f.write(data) f.write(data)
data = self.rfile.read(min(4096,remaining)) data = self.rfile.read(min(4096,remaining))
f.close()
self.send_response(200,'ok') self.send_response(200,'ok')
self.end_headers() self.end_headers()
else: else: