Merge pull request #14 from SamWhited/fix_file_leak

Fix a file handle leak
2024-11-21 16:35:04 -05:00 · 2015-07-23 10:01:30 +02:00 · 2015-07-23 10:01:30 +02:00 · db06e3edfc
commit db06e3edfc
parent 958aec3da6 f397219c27
1 changed files with 6 additions and 7 deletions
--- a/server.py
+++ b/server.py
@ -120,13 +120,12 @@ class HttpHandler(BaseHTTPRequestHandler):
                filename = os.path.join(config['storage_path'], path)
                os.makedirs(os.path.dirname(filename))
                remaining = length
-                f = open(filename,'wb')
+                with open(filename,'wb') as f:
                    data = self.rfile.read(4096)
                    while data and remaining >= 0:
                        remaining -= len(data)
                        f.write(data)
                        data = self.rfile.read(min(4096,remaining))
-                f.close()
                self.send_response(200,'ok')
                self.end_headers()
            else: