diff --git a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java index 66b3678c..33926693 100644 --- a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java +++ b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java @@ -1275,7 +1275,7 @@ public class XmppConnectionService extends Service { if (message.fixCounterpart()) { conversation.startOtrSession(message.getCounterpart().getResourcepart(), true); } else { - Log.d(Config.LOGTAG,account.getJid().toBareJid()+": could not fix counterpart for OTR message to contact "+message.getContact().getJid()); + Log.d(Config.LOGTAG,account.getJid().toBareJid()+": could not fix counterpart for OTR message to contact "+message.getCounterpart()); break; } } else { @@ -1838,6 +1838,10 @@ public class XmppConnectionService extends Service { try { X509Certificate[] chain = KeyChain.getCertificateChain(XmppConnectionService.this, alias); Pair info = CryptoHelper.extractJidAndName(chain[0]); + if (info == null) { + callback.informUser(R.string.certificate_does_not_contain_jid); + return; + } if (findAccountByJid(info.first) == null) { Account account = new Account(info.first, ""); account.setPrivateKeyAlias(alias); diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml index 8bff972d..00f18e14 100644 --- a/src/main/res/values/strings.xml +++ b/src/main/res/values/strings.xml @@ -760,4 +760,5 @@ Validate hostname with DNSSEC Server certificates that contain the validated hostname are considered verified Network is unreachable + Certificate does not contain a Jabber ID