mirror/Shipwright
1
0
Fork 0
mirror of https://github.com/HarbourMasters/Shipwright.git synced 2025-02-07 10:50:29 -05:00
Code Issues Projects Releases Wiki Activity

Fix skipping "get item" cutscene logic

Browse Source
This commit is contained in:
aMannus 2022-10-04 18:52:39 +02:00 committed by briaguya
parent a133be625e
commit f563ac733f
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
soh/src/overlays/actors/ovl_player_actor/z_player.c
View File

@ -6246,23 +6246,21 @@ s32 func_8083E5A8(Player* this, GlobalContext* globalCtx) {
} }
} }
s32 drop = giEntry.objectId; // Skip cutscenes from picking up items when they come from bushes/rocks/etc, but nowhere else.
uint8_t skipItemCutscene = CVar_GetS32("gFastDrops", 0) && interactedActor->id == ACTOR_EN_ITEM00 &&
interactedActor->params != 6 && interactedActor->params != 17;
if (gSaveContext.n64ddFlag || (globalCtx->sceneNum == SCENE_BOWLING) || // Same as above but for rando. We need this specifically for rando because we need to be enable the cutscenes everywhere else in the game
!(CVar_GetS32("gFastDrops", 0) && // because the items are randomized and thus it's important to show the get item animation.
((drop == OBJECT_GI_BOMB_1) || (drop == OBJECT_GI_NUTS) || (drop == OBJECT_GI_STICK) || uint8_t skipItemCutsceneRando = gSaveContext.n64ddFlag &&
(drop == OBJECT_GI_SEED) || (drop == OBJECT_GI_MAGICPOT) || (drop == OBJECT_GI_ARROW))) && Item_CheckObtainability(giEntry.itemId) != ITEM_NONE &&
(Item_CheckObtainability(giEntry.itemId) == ITEM_NONE)) { interactedActor->id == ACTOR_EN_ITEM00 &&
interactedActor->params != 6 && interactedActor->params != 17;
if (gSaveContext.n64ddFlag && // Show cutscene when picking up a item that the player doesn't own yet.
((interactedActor->id == ACTOR_EN_ITEM00 && // We want to ALWAYS show "get item animations" for items when they're randomized to account for
(interactedActor->params != 6 && interactedActor->params != 17)) || // randomized freestanding items etc, but we still don't want to show it every time you pick up a consumable from a pot/bush etc.
(interactedActor->id == ACTOR_EN_KAREBABA || interactedActor->id == ACTOR_EN_DEKUBABA))) { if ((globalCtx->sceneNum == SCENE_BOWLING || Item_CheckObtainability(giEntry.itemId) == ITEM_NONE || gSaveContext.n64ddFlag) && !skipItemCutscene && !skipItemCutsceneRando) {
func_8083E4C4(globalCtx, this, &giEntry);
this->getItemId = GI_NONE;
this->getItemEntry = (GetItemEntry)GET_ITEM_NONE;
return 0;
}
func_808323B4(globalCtx, this); func_808323B4(globalCtx, this);
func_8083AE40(this, giEntry.objectId); func_8083AE40(this, giEntry.objectId);
@ -6278,6 +6276,7 @@ s32 func_8083E5A8(Player* this, GlobalContext* globalCtx) {
return 1; return 1;
} }
// Don't show cutscene when picking up an item
func_8083E4C4(globalCtx, this, &giEntry); func_8083E4C4(globalCtx, this, &giEntry);
this->getItemId = GI_NONE; this->getItemId = GI_NONE;
this->getItemEntry = (GetItemEntry)GET_ITEM_NONE; this->getItemEntry = (GetItemEntry)GET_ITEM_NONE;