Remove comment and stuff useless

This commit is contained in:
Baoulettes 2022-05-20 02:42:53 +02:00 committed by GitHub
parent 6229233b5f
commit bb44350a8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -391,28 +391,22 @@ namespace SohImGui {
} }
void EnhancementCombobox(const char* name, const char* ComboArray[], s16 FirstTimeValue = -1){ void EnhancementCombobox(const char* name, const char* ComboArray[], s16 FirstTimeValue = -1){
//The -1 do not force the maker to add a default first value
if (FirstTimeValue < 0){ if (FirstTimeValue < 0){
//If there is no default value it will pass this condition and so to prevent crash we set 0
FirstTimeValue = 0; FirstTimeValue = 0;
} }
//And now we set the default value to the CVar fallback
//This way we ensure to show the number we want the user to see the first time
s16 selected=CVar_GetS32(name, FirstTimeValue); s16 selected=CVar_GetS32(name, FirstTimeValue);
//Now we set the fetched value to the drop box.
//This way if a player set something else than the default it will show their selection.
s16 DefaultValue=selected; s16 DefaultValue=selected;
if (ImGui::BeginCombo("##name", ComboArray[DefaultValue])) { if (ImGui::BeginCombo("##name", ComboArray[DefaultValue])) {
//char *[] got two extra : '\123' (begin) '\n' (last) s16 ComboxSize = sizeof(&ComboArray);
s16 ComboxSize = sizeof(&ComboArray)-2;
//Seem like it does not count entry 0 so it end up doing 0, 1, 2 and count 2 not 3
for (uint8_t i = 0; i <= ComboxSize; i++) { for (uint8_t i = 0; i <= ComboxSize; i++) {
if (strlen(ComboArray[i]) > 1) {
if (ImGui::Selectable(ComboArray[i], i==selected)) { if (ImGui::Selectable(ComboArray[i], i==selected)) {
CVar_SetS32(name, i); CVar_SetS32(name, i);
selected=i; selected=i;
needs_save = true; needs_save = true;
} }
} }
}
ImGui::EndCombo(); ImGui::EndCombo();
} }
} }