From 8c8111c7b8643e337f2b149cf317bf02a5ea79b4 Mon Sep 17 00:00:00 2001
From: Christopher Leggett <chris@leggett.dev>
Date: Wed, 21 Dec 2022 00:31:51 -0500
Subject: [PATCH] Small improvement to sfx randomize button. (#2219)

Should result in less allocations.
---
 soh/soh/Enhancements/sfx-editor/SfxEditor.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/soh/soh/Enhancements/sfx-editor/SfxEditor.cpp b/soh/soh/Enhancements/sfx-editor/SfxEditor.cpp
index f14b83b86..43367f749 100644
--- a/soh/soh/Enhancements/sfx-editor/SfxEditor.cpp
+++ b/soh/soh/Enhancements/sfx-editor/SfxEditor.cpp
@@ -303,10 +303,9 @@ void Draw_SfxTab(const std::string& tabId, const std::map<u16, std::tuple<std::s
         ImGui::SameLine();
         ImGui::PushItemWidth(-FLT_MIN);
         if (ImGui::Button(randomizeButton.c_str())) {
+            auto it = map.begin();
             while (true) {
-                auto it = map.begin();
-                std::advance(it, rand() % map.size());
-                const auto& [value, seqData] = *it;
+                const auto& [value, seqData] = *std::next(it, rand() % map.size());
                 const auto& [name, sfxKey, seqType] = seqData;
                 if (seqType & type) {
                     CVar_SetS32(cvarKey.c_str(), value);